Skip to content

GFDL to main 2025-04-23 #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 158 commits into from
Closed

GFDL to main 2025-04-23 #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
158 commits
Select commit Hold shift + click to select a range
51b4fb6
Bug fix for write_energy with short dt (#749)
herrwang0 Nov 30, 2024
20888e3
Remove extra copy of compute_global_grid_integrals
Hallberg-NOAA Nov 30, 2024
ac6e43d
Make REMAPPING_USE_OM4_SUBCELLS the default
awallcraft Nov 22, 2024
cfb53f1
Removed default for mandatory time scale in OBCs
adcroft Dec 2, 2024
0337147
Adds a vector of default values to get_param_real_array()
adcroft Nov 26, 2024
0fdb47c
FMS API: Convert real kind of constants
marshallward Dec 8, 2024
f920c1a
Inline harmonic analysis (#744)
c2xu Dec 9, 2024
78a7936
Tidal angular frequency has units [rad s-1] (#764)
awallcraft Dec 9, 2024
00fdee4
Refactor of vertical reconstruction adding six new schemes (#741)
adcroft Dec 11, 2024
61e3bcf
add diagnostic for Kd_Work related to the Kd_add part (#765)
raphaeldussin Dec 11, 2024
3c39818
+*Obsolete WIND_CONFIG = "SCM_ideal_hurr" (#770)
Hallberg-NOAA Dec 11, 2024
af76c6c
*Fix a bug when EPBL_ORIGINAL_PE_CALC is false
Hallberg-NOAA Sep 4, 2024
8f0a593
+Add EPBL_MLD_ITER_BUG runtime parameter
Hallberg-NOAA Nov 18, 2024
18dffbf
+Add run-time ability to debug ePBL sensitivities
Hallberg-NOAA Nov 17, 2024
2e8e2a5
+Add and test find_Kd_from_PE_chg
Hallberg-NOAA Nov 21, 2024
4a53050
+(*)Add ePBL bottom boundary mixing option
Hallberg-NOAA Sep 4, 2024
d8a270b
+Add DECAY_ADJUSTED_BBL_TKE option for ePBL BBL
Hallberg-NOAA Nov 29, 2024
a3cef87
+Add optional unscale argument to reproducing_sum
Hallberg-NOAA Dec 6, 2024
7060d51
+Add RZL2_to_kg element to unit_scale_type
Hallberg-NOAA Dec 11, 2024
8dcb6a4
Work in rescaled units in write_energy
Hallberg-NOAA Dec 11, 2024
a4d13e8
Use reproducing_sum with unscale in 5 places
Hallberg-NOAA Dec 11, 2024
e6e0870
Bug fix related to directional internal wave drag (#774)
c2xu Dec 12, 2024
dae6226
Fix indexing error in extract_surface_state
herrwang0 Dec 21, 2024
8062d20
Minor change of SSH check in extract_surface_state
herrwang0 Dec 21, 2024
9371bb0
Recover diagnostic "SSH_inst"
herrwang0 Dec 21, 2024
9564493
Update MOM_wave_interface.F90 (#784)
Zeracesharon Dec 30, 2024
45add79
Updates to use EPBL_BBL_EFFIC
Dec 31, 2024
fcf5fff
Move MOM_generic_tracer with no changes (#22)
theresa-cordero Dec 31, 2024
81ea4b6
Corrected the rescaling of 5 KPP diagnostics
Hallberg-NOAA Jan 1, 2025
7846b80
+Add a vector of defaults to get_param_array_int
Hallberg-NOAA Jan 1, 2025
7ca5ed9
set descale in reproducing_sum_3d
yichengt900 Jan 6, 2025
3a623f0
Fix ALE_sponge tendency diagnostic units
Hallberg-NOAA Dec 30, 2024
5ccb388
Refactor horizontally_average_field
Hallberg-NOAA Dec 7, 2024
db94db8
+Refactor homogenize_field and revise its interface
Hallberg-NOAA Dec 7, 2024
3ad5cf2
Revise the ice_shelf dimensional rescaling
Hallberg-NOAA Dec 7, 2024
5d3d504
(*)Conversion arguments for ice shelf scalar diags
Hallberg-NOAA Jan 1, 2025
82d44fb
Users set solo driver forcing time records per day
Hallberg-NOAA Jan 2, 2025
7a45c61
Merge branch 'main' into dev/gfdl
marshallward Jan 13, 2025
30df138
Fix dimensional rescaling in predict_MEKE
Hallberg-NOAA Jan 13, 2025
10d9523
Refactor SAL in MOM_PressureForce_FV
herrwang0 Jul 22, 2024
89fec6e
Add option for SAL to use bottom pressure anomaly
herrwang0 Jul 27, 2024
402949e
Rename variables with tides in Pressure Force
herrwang0 Sep 27, 2024
8039c33
Alternative method for SAL and tides in Boussinesq
herrwang0 Sep 27, 2024
36f763c
Remove rescaling bottom pressure in SAL
herrwang0 Oct 7, 2024
73a625d
Add answer date flag for tide/SAL
herrwang0 Jan 7, 2025
8e0b83c
Refactor Love_scaling calculation in SAL module
herrwang0 Jan 13, 2025
8249510
+Refactor MOM_opacity to replace hard-coded params
Hallberg-NOAA Dec 11, 2024
585d24d
implement spatially varying decay rates for internal tides leakage (#…
raphaeldussin Jan 14, 2025
dd1f3f5
Add ice shelf pressure initialisation bug fix (#800)
claireyung Jan 14, 2025
d8da512
+Add the optional argument old_name to get_param
Hallberg-NOAA Jan 5, 2025
400c982
+Add grid_unit_to_L to the ocean_grid_type
Hallberg-NOAA Dec 4, 2024
14f2c97
Update particles_run call to allow accurate particle advection using …
cspencerjones Dec 23, 2024
40a59f7
+Remove dyn_horgrid_type%Rad_Earth
Hallberg-NOAA Dec 8, 2024
73514f2
Nodal modulation
c2xu Sep 6, 2024
54feb6f
Correct unit conversion for BS_coeff_h diagnostic
Hallberg-NOAA Dec 12, 2024
83efb99
Streaming Filter
c2xu Dec 10, 2024
bf35f31
Merge branch 'dev/gfdl' into rescale_predict_MEKE
theresa-cordero Jan 21, 2025
7a5adc7
+Refactor the spatial mean calculations
Hallberg-NOAA Dec 7, 2024
576fb41
Diagnose area integrated fluxes in rescaled units
Hallberg-NOAA Jan 19, 2025
83c7119
Fix rescaling of internal tide of debugging code
Hallberg-NOAA Nov 30, 2024
3be1543
Corrected many unit descriptions in comments
Hallberg-NOAA Jan 7, 2025
094eb54
Fix rotation in set_coupler_type_data
marshallward Jan 21, 2025
320aac2
Remove implicit copies in CT_extract_data rotation
marshallward Jan 23, 2025
2ade897
Refactor spherical_harmonics_forward
Hallberg-NOAA Dec 7, 2024
93227b3
Rescale 7 ice shelf variables
Hallberg-NOAA Jan 5, 2025
fcdf8db
+Rename visc%TKE_BBL to visc%BBL_meanKE_loss
Hallberg-NOAA Jan 8, 2025
e856749
+Rename fluxes%TKE_tidal to fluxes%BBL_tidal_dis
Hallberg-NOAA Jan 8, 2025
4f53784
+Add EPBL_BBL_TIDAL_EFFIC
Hallberg-NOAA Jan 19, 2025
a645328
+(*)EPBL_BBL_EFFIC_BUG & DRAG_DIFFUSIVITY_ANSWER_DATE
Hallberg-NOAA Jan 20, 2025
9fd0ecc
+Add alternate gravity variable GV%g_Earth_Z_T2
Hallberg-NOAA Jan 6, 2025
35d7e76
Revise rescaling in bulkmixedlayer
Hallberg-NOAA Jan 6, 2025
2370f7c
Rescale strat_floor
Hallberg-NOAA Jan 8, 2025
a40bbb9
Add Option to Specify Tracer Advection Time Step (#757)
theresa-cordero Jan 29, 2025
c54334e
+Add optional conversion argument to register_field
Hallberg-NOAA Dec 14, 2024
5c335ba
Specify conversion factors in write_energy
Hallberg-NOAA Dec 14, 2024
d6f3fa0
Fix 4 conversion arguments to var_desc calls
Hallberg-NOAA Dec 29, 2024
b239629
Deprecate TIDE_SAL_SCALAR_VALUE (#819)
herrwang0 Jan 31, 2025
68ece77
Calculate volo in scaled units
Hallberg-NOAA Jan 31, 2025
802248f
Rename masked_area in compute_global_grid_integral
Hallberg-NOAA Jan 31, 2025
6bf8c67
Fix the syntax or substance in 10 comment units
Hallberg-NOAA Jan 31, 2025
cbb8bfa
Switched the placeholder element of file_OBC_CS
Hallberg-NOAA Jan 31, 2025
bb66d8a
Merge branch 'main' into dev/gfdl
marshallward Feb 3, 2025
d4770e8
Correct bug in kappa shear viscosity with vertex shear option. (#824)
breichl Feb 5, 2025
1877681
+Add PHILLIPS_ANSWER_DATE runtime parameter
Hallberg-NOAA Dec 4, 2024
9aaf5e1
+Add zero_zeros optional arg to MOM_write_field
Hallberg-NOAA Dec 21, 2024
b41f0a4
+Add turns argument to MOM_read_data
Hallberg-NOAA Dec 23, 2024
463424c
(*)+Modified MOM_restart to fix rotated restarts
Hallberg-NOAA Dec 23, 2024
d5fd567
Describe the units of 33 real function results
Hallberg-NOAA Feb 5, 2025
84a7bc0
Add MASS_WEIGHT_IN_PGF_VANISHED_ONLY to modify mass weighting in PGF …
claireyung Feb 13, 2025
ec60bf1
+Obsoleted INTERNAL_TIDE_CORNER_ADVECT
Hallberg-NOAA Feb 6, 2025
075f8b3
Add option to use BT_CONT to calculate `dtbt` (#823)
herrwang0 Feb 13, 2025
38a0cb0
MOM_murmur_hash: MurmurHash3 implementation
marshallward Feb 7, 2025
c69f59e
+Find fluxes%netFWGlobalAdj in recsaled units
Hallberg-NOAA Feb 5, 2025
93067d0
Dimensional rescaling in MOM_state_stats
Hallberg-NOAA Feb 6, 2025
3b3fb5e
Frequency-dependent internal wave drag (#815)
c2xu Feb 16, 2025
9924a19
Passing shelf_sfc_mass_flux to ice shelf (#818)
OlgaSergienko Feb 18, 2025
a71e0fb
Debugging checksum on full range of Kh_h and Kh_q (#822)
Hallberg-NOAA Feb 19, 2025
51b1515
Correct indenting in ePBL_column
Hallberg-NOAA Feb 18, 2025
1344e7c
Add MLD_out to diagnose MLD (#832)
theresa-cordero Feb 19, 2025
0162098
+Revise the rescaled units of forces%tau_mag
Hallberg-NOAA Jan 10, 2025
e187090
Remove Prandtl_turb in vertvisc_type
herrwang0 Feb 19, 2025
809d56e
Refactor a few lines in vertical viscosity
herrwang0 Feb 19, 2025
ad0a8b8
+Add the new interface field_checksum
Hallberg-NOAA Dec 21, 2024
090e323
Refactor get_depth_list_checksum
Hallberg-NOAA Dec 21, 2024
86ed81f
Use field_checksum in save_restart & restore_state
Hallberg-NOAA Dec 28, 2024
5f23058
Bugfix for mixing up `Rho0` and `rho_ref` in Boussinesq PGF (#837)
herrwang0 Feb 24, 2025
9e7cfe9
Alternative interface to EQN_OF_STATE="LINEAR" (#842)
awallcraft Feb 25, 2025
5e4f97b
Fix interior obcs (#814)
kshedstrom Feb 26, 2025
23b2049
Move Regridding and Remapping Out of step_MOM_thermo (#761)
theresa-cordero Mar 3, 2025
3142c3f
Add `RESET_INTXPA_INTEGRAL_FLATTEST` option to pressure gradient (#843)
claireyung Mar 3, 2025
e3e9c69
Update btstep negative eta warning (#844)
awallcraft Mar 4, 2025
53bcb50
+Steps to correct Kelvin_initialization issues
Hallberg-NOAA Feb 22, 2025
4f0c1c6
Updates MOM_kappa_shear averaging and diagnostics. (#846)
breichl Mar 6, 2025
9e3cc84
*Improvements to internal Kelvin wave (#849)
kshedstrom Mar 6, 2025
9aa04ee
Add INTERFACE_FILTER_DT_BUG (#850)
awallcraft Mar 10, 2025
0180d52
Move some parts of btstep() into subroutines (#845)
theresa-cordero Mar 10, 2025
88306bd
Expand error message when OBC files are missing (#851)
theresa-cordero Mar 12, 2025
8f8893f
Adding cmor names for temp and salt in MOM_diagnostics
Mar 17, 2025
66e96a4
Add option to convert salinity restoring for absolute salinity
Mar 18, 2025
c73ad58
Change the default setting of salt restore conversion to false
Mar 18, 2025
936c6b8
Apply OBCs earlier in btstep
Hallberg-NOAA Mar 12, 2025
dbba585
Split apply_velocity_OBCs into two routines
Hallberg-NOAA Mar 14, 2025
5eeaeff
Calculate transports outside of btloop_update_u
Hallberg-NOAA Mar 14, 2025
f9e1a84
Reduce the size of barotropic diagnostic arrays
Hallberg-NOAA Mar 18, 2025
47733ed
Horvisc: Reorder if-blocks in rescaled Kh
marshallward Mar 19, 2025
792a061
Correct temperature and salinity mean diagnostics when using conserva…
breichl Mar 20, 2025
0daa4ff
Move barotropic time stepping into btstep_timeloop
Hallberg-NOAA Mar 20, 2025
74f5474
Add variable dimensions to available_diags file
jkrasting Mar 21, 2025
d29f8fd
Allow some tracers to use a different advection scheme (#866)
ygahounzo Mar 27, 2025
d6a2fe8
.testing: Fix optimized target paths
marshallward Mar 28, 2025
065b917
.testing: Generalize the character limit for perf
marshallward Mar 28, 2025
621710f
Merge branch 'main' into dev/gfdl
marshallward Apr 4, 2025
41e8f2a
Disable cray-libsci for Intel in Gitlab .testing
marshallward Apr 4, 2025
d1bd2c3
*Restore PFv parentheses for symmetry with FMAs
Hallberg-NOAA Apr 6, 2025
8be87a2
Add merged Coriolis arrays in MOM_barotropic
Hallberg-NOAA Mar 21, 2025
084a5db
Fix the incorrect index for v-point in the doc
gmao-cda Apr 7, 2025
6eca7bb
+Refactor totalTandS to work with scaled variables
Hallberg-NOAA Feb 5, 2025
eb9061d
Kd work and buoyancy flux diagnostics (#853)
breichl Apr 14, 2025
1dae3f0
Restructure CI tests as a single workflow
marshallward Jan 17, 2024
942acdd
Update to AX_FC_REAL8 macro (#856)
marshallward Apr 16, 2025
d332ae9
Append timestamp to chksum_diag output
marshallward Apr 15, 2025
b232aba
Use sorted chksum_diag for diagnostic regression
marshallward Apr 15, 2025
f266a31
Add decomposed energy diagnostics from BT solver
herrwang0 Apr 20, 2023
c23aad6
Add diagnostics for tides and SAL
herrwang0 Mar 7, 2025
991524b
*Restore Cor_v parentheses for symmetry with FMAs
Hallberg-NOAA Apr 18, 2025
f2e67e6
Zero out bt_pgf_u at OBC points
Hallberg-NOAA Apr 17, 2025
7bae43f
Initialize use_ice_shelf in ALE_regridding_and_remapping
JosephMouallem Apr 2, 2025
24e20dc
Set use_ice_shelf dynamically
adcroft Apr 21, 2025
488058c
Eliminate OBC loops in btloop_update_u
Hallberg-NOAA Mar 27, 2025
657b179
Add new subroutine btloop_find_PF
Hallberg-NOAA Mar 31, 2025
8951de7
Simpler btloop_eta_predictor
Hallberg-NOAA Apr 5, 2025
8ae091b
Eliminate eta_PF_BT pointer in btstep_timeloop
Hallberg-NOAA Apr 6, 2025
3f1a0d0
Refactor barotropic OBC code
Hallberg-NOAA Apr 10, 2025
fe71318
Split western and eastern OBC loops
Hallberg-NOAA Apr 11, 2025
812d585
Barotropic OBC memory and halo update cleanup
Hallberg-NOAA Apr 12, 2025
c267ed6
Add btloop_add_dyn_PF and refactor OBCs in btcalc
Hallberg-NOAA Apr 13, 2025
6539f69
Refactor btcalc to reduce duplicated code
Hallberg-NOAA Apr 14, 2025
484b917
Merge branch 'main' into merge_main_ncar_02_2025
Hallberg-NOAA Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/macos-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ runs:
run: |
cd .testing
echo "FCFLAGS_DEBUG = -g -O0 -Wextra -Wno-compare-reals -fbacktrace -fcheck=bounds" >> config.mk
echo "FCFLAGS_REPRO = -g -O2 -fbacktrace" >> config.mk
echo "FCFLAGS_REPRO = -g -O1 -ffp-contract=off -fbacktrace" >> config.mk
echo "FCFLAGS_INIT = -finit-real=snan -finit-integer=2147483647 -finit-derived" >> config.mk
echo "FCFLAGS_FMS = -g -fbacktrace -O0" >> config.mk
cat config.mk
Expand Down
30 changes: 0 additions & 30 deletions .github/workflows/coupled-api.yml
View file
Open in desktop

This file was deleted.

42 changes: 0 additions & 42 deletions .github/workflows/coverage.yml
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions .github/workflows/documentation-and-style.yml
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions .github/workflows/expression.yml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions .github/workflows/macos-regression.yml
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions .github/workflows/macos-stencil.yml
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions .github/workflows/other.yml
View file
Open in desktop

This file was deleted.

75 changes: 0 additions & 75 deletions .github/workflows/perfmon.yml
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions .github/workflows/regression.yml
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions .github/workflows/stencil.yml
View file
Open in desktop

This file was deleted.

Loading
Loading