Skip to content

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Aug 24, 2025

Reported by hacksandhops and Ada Logic.

@iamamyth
Copy link

Windows build fails on this branch. I didn't inspect the output close enough to tell if the failure owes to the new code, but I note a problem with boost string code, and this commit introduces a new boost string-related call.

@nahuhh
Copy link
Contributor

nahuhh commented Aug 28, 2025

Windows build fails on this branch. I didn't inspect the output close enough to tell if the failure owes to the new code, but I note a problem with boost string code, and this commit introduces a new boost string-related call.

I think the failure is unrelated, caused by boost version 1.89 issues. The windows CI has been failing for a while

cc @0xFFFC0000

@selsta
Copy link
Collaborator Author

selsta commented Aug 28, 2025

yes, build failure is unrelated

@0xFFFC0000
Copy link
Collaborator

Windows build is something related to ICU and boost.locale. It started when pacman switched to boost 1.89. I am looking into this as we speak [1].

https://github.com/msys2/MINGW-packages/pull/25219/files

Reported by hacksandhops and Ada Logic.
@tobtoht tobtoht merged commit 07dcc49 into monero-project:master Aug 30, 2025
17 of 18 checks passed
@selsta selsta deleted the port branch September 8, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants