-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
epee: only parse valid port #10056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epee: only parse valid port #10056
Conversation
Windows build fails on this branch. I didn't inspect the output close enough to tell if the failure owes to the new code, but I note a problem with boost string code, and this commit introduces a new boost string-related call. |
I think the failure is unrelated, caused by boost version 1.89 issues. The windows CI has been failing for a while cc @0xFFFC0000 |
yes, build failure is unrelated |
Windows build is something related to ICU and boost.locale. It started when pacman switched to boost 1.89. I am looking into this as we speak [1]. https://github.com/msys2/MINGW-packages/pull/25219/files |
Reported by hacksandhops and Ada Logic.
Reported by hacksandhops and Ada Logic.