CMake: fix msys/ICU compilation failure #10069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selsta
approved these changes
Sep 8, 2025
tobtoht
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been reported upstream [1,2]. I am not sure when they are gonna fix this. But for now, this is a temporary fix to be able to compile on msys2.
In case anybody wants to raise a concern about linking the shared ICU in the static build. I have to say, there is no static ICU link in boost at the moment because of an upstream bug [1]. You either have to link the shared ICU (which
Boost.Localelinks to it) or you get the linker error.Green MSYS2 CI on my fork: https://github.com/0xFFFC0000/monero/actions/runs/17532831145/job/49792012836