Skip to content

rpc: remove COMMAND_RPC_FAST_EXIT #9423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

rpc: remove COMMAND_RPC_FAST_EXIT #9423

merged 1 commit into from
Aug 13, 2024

Conversation

hinto-janai
Copy link
Contributor

Removes the unused COMMAND_RPC_FAST_EXIT type from the daemon RPC.

This type is leftover from the (now removed) /fast_exit endpoint from #252.

@hinto-janai hinto-janai mentioned this pull request Aug 6, 2024
Closed
25 tasks
@hinto-janai hinto-janai marked this pull request as ready for review August 6, 2024 01:09
selsta
selsta reviewed Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should CORE_RPC_VERSION_MINOR be bumped?

@jeffro256
Copy link
Contributor

Doesn't practically affect the RPC interface, so I'd say no.

@luigi1111 luigi1111 merged commit 4bb0042 into monero-project:master Aug 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@selsta selsta selsta left review comments

@vtnerd vtnerd vtnerd approved these changes

@jeffro256 jeffro256 jeffro256 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hinto-janai @jeffro256 @vtnerd @selsta @luigi1111