Skip to content

Conversation

dakusui
Copy link
Contributor

@dakusui dakusui commented Feb 24, 2025

Hi! Thank you for making the nice project open-source! ;)
I am working on making insdog work/be developed in Linux platform.
Here's a PR, please have a look at it!

@dakusui dakusui marked this pull request as draft February 24, 2025 23:31
@dakusui dakusui changed the title Make bootstrap.sh/env.rc work on Linux platforms. wip: Make bootstrap.sh/env.rc work on Linux platforms Feb 24, 2025
@dakusui
Copy link
Contributor Author

dakusui commented Feb 24, 2025

Currently, I am getting a following warning during build.sh build.
Except for that things are working fine, it seems.

[INFO] Running jp.co.moneyforward.autotest.ut.builtins.TableQueryTest
Playwright Host validation warning: 
╔══════════════════════════════════════════════════════╗
║ Host system is missing dependencies to run browsers. ║
║ Missing libraries:                                   ║
║     libicudata.so.70                                 ║
║     libicui18n.so.70                                 ║
║     libicuuc.so.70                                   ║
║     libvpx.so.7                                      ║
╚══════════════════════════════════════════════════════╝
    at validateDependenciesLinux (/tmp/playwright-java-11220505117427655116/package/lib/server/registry/dependencies.js:216:9)
    at async Registry._validateHostRequirements (/tmp/playwright-java-11220505117427655116/package/lib/server/registry/index.js:603:43)
    at async Registry._validateHostRequirementsForExecutableIfNeeded (/tmp/playwright-java-11220505117427655116/package/lib/server/registry/index.js:701:7)
    at async Registry.validateHostRequirementsForExecutablesIfNeeded (/tmp/playwright-java-11220505117427655116/package/lib/server/registry/index.js:690:43)
    at async t.<anonymous> (/tmp/playwright-java-11220505117427655116/package/lib/cli/program.js:119:7)
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.099 s -- in jp.co.moneyforward.autotest.ut.builtins.TableQueryTest

@dakusui dakusui changed the title wip: Make bootstrap.sh/env.rc work on Linux platforms fix: Make bootstrap.sh/env.rc work on Linux platforms Feb 25, 2025
@dakusui dakusui marked this pull request as ready for review February 25, 2025 19:24
@dakusui
Copy link
Contributor Author

dakusui commented Mar 10, 2025

Hi, there!
I've checked the change works on my macOS laptop.
Cheers ;)

Copy link
Collaborator

@sukezan sukezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I tried it on Ubuntu in my macOS. And confirmed that it works.

@dakusui
Copy link
Contributor Author

dakusui commented Mar 31, 2025

Glad to hear that! UTM is a really nice solution for this, isn't it.
I'm waiting for your merge as I don't see any merge button on my end :)

@sukezan sukezan merged commit 65bb930 into moneyforward:main Mar 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants