Skip to content

Conversation

@bohyunjung
Copy link
Member

@bohyunjung bohyunjung commented Apr 27, 2025

Move embedding model description to a better place.

AS IS TO BE
Screenshot 2025-04-27 at 19 00 09 Screenshot 2025-04-27 at 18 59 46

@bohyunjung bohyunjung requested a review from ajosh0504 April 27, 2025 09:59
@ajosh0504
Copy link
Collaborator

ajosh0504 commented May 1, 2025

I put it in that position because CODE_BLOCK_3 is where you need that reference documentation. General idea was to keep documentation closest to where it's needed.

@bohyunjung
Copy link
Member Author

I see. That makes sense for providing the link to the reference documentation before the actual usage.

There was feedback that it would be beneficial to add a link to the embedding model (CLIP) where it is first introduced in the code, so that developers can understand what clip-ViT-B-32 means. What do you think about providing a general link to the model immediately after the Step 3 header, while keeping the reference link in place as is?

@ajosh0504
Copy link
Collaborator

@bohyunjung Can do! I will add this in a separate PR with a few other changes. Closing this one.

@ajosh0504 ajosh0504 closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants