fix(e2e): check preference after async operation during connection

Author: gribnoysup

packages/compass-connections/src/components/end-of-life-connection-modal.tsx

@@ -20,7 +20,8 @@ const modalBodyStyles = css({
 
 export function showEndOfLifeMongoDBWarningModal(
   connectionInfo?: ConnectionInfo,
-  version?: string
+  version?: string,
+  closeSignal?: AbortSignal
 ) {
   return showConfirmation({
     title: 'End-of-life MongoDB Detected',
@@ -48,5 +49,6 @@ export function showEndOfLifeMongoDBWarningModal(
         </Link>
       </>
     ),
+    signal: closeSignal,
   });
 }

packages/compass-connections/src/stores/connections-store-redux.ts

@@ -2243,15 +2243,13 @@ async function shouldShowEndOfLifeWarning(
   debug: Logger['debug']
 ) {
   try {
-    const { showEndOfLifeConnectionModal, networkTraffic } =
-      preferences.getPreferences();
-    if (!showEndOfLifeConnectionModal) {
-      return;
-    }
     const latestEndOfLifeServerVersion = await getLatestEndOfLifeServerVersion(
-      networkTraffic
+      preferences.getPreferences().networkTraffic
+    );
+    return (
+      preferences.getPreferences().showEndOfLifeConnectionModal &&
+      isEndOfLifeVersion(serverVersion, latestEndOfLifeServerVersion)
     );
-    return isEndOfLifeVersion(serverVersion, latestEndOfLifeServerVersion);
   } catch (err) {
     debug(
       'failed to get instance details to determine if the server version is end-of-life',
@@ -2265,10 +2263,24 @@ export const showEndOfLifeMongoDBWarningModal = (
   connectionId: string,
   version: string
 ): ConnectionsThunkAction<void> => {
-  return (_dispatch, getState, { track }) => {
+  return (_dispatch, getState, { track, preferences }) => {
+    const abortController = new AbortController();
+    const removeListener = preferences.onPreferenceValueChanged(
+      'showEndOfLifeConnectionModal',
+      (shouldShow) => {
+        if (!shouldShow) {
+          abortController.abort();
+          removeListener();
+        }
+      }
+    );
     const connectionInfo = getCurrentConnectionInfo(getState(), connectionId);
     track('Screen', { name: 'end_of_life_mongodb_modal' }, connectionInfo);
-    void _showEndOfLifeMongoDBWarningModal(connectionInfo, version);
+    void _showEndOfLifeMongoDBWarningModal(
+      connectionInfo,
+      version,
+      abortController.signal
+    );
   };
 };