feature/COMPASS-9629 expose onNodeClick and nodeDragThreshold component props #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
commented
Jul 29, 2025
| @@ -181,7 +191,15 @@ export interface DiagramProps { | |||
| /** | |||
| * Whether to only render elements that are currently visible in the viewport. | |||
| * This can improve performance for large diagrams. | |||
| * @defaults true | |||
| * @default true | |||
There was a problem hiding this comment.
Drive-by, defaults is not really a jsdoc directive, default is, probably a typo
mabaasit
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description
Some interaction with diagram in compass requires us to react to the node click event to the component, we're currently doing this by just ignoring typescript errors as the props are being passed through, but would like to remove the
ts-expect-errorstatements from the code. Also when adding node click, we realised that the defaultnodeDragThresholdis too low, so clicks are not registering too often, so this is another prop that is getting exposed in this patchNotes for Reviewers
N/A
📸 Screenshots/Screencasts
N/A
Before
N/A
After
N/A