admin.NewThirdPartyIntegration creates object with bad defaults, unusable for some integrations (Prometheus)

[JohanLindvall]

Describe the bug
Recent changes to admin.NewThirdPartyIntegration appear to set fields to default values. These fields are serialized, but not accepted by at least one integration (Prometheus)

(Error code: "INVALID_ATTRIBUTE") Detail: Invalid attribute sendCollectionLatencyMetrics specified. Reason: Bad Request. Params: [sendCollectionLatencyMetrics], BadRequestDetail: "}

Expected behavior
No error.

Additional context
SDK version go.mongodb.org/atlas-sdk/v20250312008 v20250312008.0.0

Fix
If I instead of admin.NewThirdPartyIntegration directly construct an empty admin.ThirdPartyIntegration object, the integration works

Sample code
This is the failing code

func createThirdPartyIntegration(config *IntegrationConfig) *admin.ThirdPartyIntegration {
	tpi := admin.NewThirdPartyIntegration()
	tpi.SetEnabled(true)
	tpi.SetType("PROMETHEUS")
	tpi.SetServiceDiscovery("http")
	tpi.SetUsername(config.PrometheusUsername)
	tpi.SetPassword(config.PrometheusPassword)
	return tpi
}

func createPrometheusIntegration(ctx context.Context, client *Client, groupID string, config *IntegrationConfig) ([]admin.ThirdPartyIntegration, error) {
	tpi := createThirdPartyIntegration(config)
	request := client.api.ThirdPartyIntegrationsApi.CreateGroupIntegration(ctx, *tpi.Type, groupID, tpi)
	integrations, _, err := request.Execute()

	if err != nil {
		return nil, err
	}
	return *integrations.Results, nil
}

[github-actions]

Thanks for opening this issue. The ticket CLOUDP-350321 was created for internal tracking.

[lantoli]

thanks @JohanLindvall for opening the issue.

As you comment, it's better to create an empty struct and then call Set methods, or alternatively create the struct directly with the values you know, e.g.:

	tpi := &admin.ThirdPartyIntegration{
		Enabled:          admin.PtrBool(true),
		Type:             admin.PtrString("PROMETHEUS"),
		ServiceDiscovery: admin.PtrString("http"),
		Username:         admin.PtrString(config.PrometheusUsername),
		Password:         admin.PtrString(config.PrometheusPassword),
	}

NewThirdPartyIntegration doesn't work fine in this situation because Go doesn't support polymorphism, so we join together all attributes from all integrations. If for example default value for sendCollectionLatencyMetrics is false in DATADOG integration, NewThirdPartyIntegration will set that attribute to false, but it's an error to set it for other integrations.

So it's better to set explicitly the attributes you need.

I'm closing the issue but don't hesitate to reopen again if you have further questions.