Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 9, 2025

Description

Summary of Changes

This PR removes support for the constructor overload new ObjectId(<number>).

Notes for Reviewers

What is the motivation for this change?

Release Highlight

ObjectId constructor no longer accepts a number

If you wish to create an ObjectId from a numeric timestamp, use ObjectId.createFromTime() instead.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review October 10, 2025 14:09
@baileympearson baileympearson requested a review from a team as a code owner October 10, 2025 14:09
@dariakp dariakp self-assigned this Oct 10, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 10, 2025
@dariakp dariakp merged commit 21cc3ff into main Oct 10, 2025
9 checks passed
@dariakp dariakp deleted the NODE-5763 branch October 10, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants