Apply suggestions from code review

GromNaN · alcaeus · web-flow · commit 1c1c06fc2871 · 2024-07-19T10:03:46.000+02:00
Co-authored-by: Andreas Braun &lt;git@alcaeus.org&gt;
diff --git a/tests/EmbeddedRelationsTest.php b/tests/EmbeddedRelationsTest.php
@@ -958,7 +958,7 @@ public function testUnsetPropertyOnEmbed()
         $user->addresses->first()->save();
 
         $user = User::where('name', 'John Doe')->first();
-        $this->assertSame(null, $user->addresses->get(0)->city);
+        $this->assertNull($user->addresses->get(0)->city);
         $this->assertSame('Tokyo', $user->addresses->get(1)->city);
 
         // Unset and reset property
@@ -967,7 +967,7 @@ public function testUnsetPropertyOnEmbed()
         $user->addresses->get(1)->save();
 
         $user = User::where('name', 'John Doe')->first();
-        $this->assertSame(null, $user->addresses->get(0)->city);
+        $this->assertNull($user->addresses->get(0)->city);
         $this->assertSame('Kyoto', $user->addresses->get(1)->city);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ public function testUnsetPropertyOnEmbed()`
`958`	`958`	`$user->addresses->first()->save();`
`959`	`959`
`960`	`960`	`$user = User::where('name', 'John Doe')->first();`
`961`		`- $this->assertSame(null, $user->addresses->get(0)->city);`
	`961`	`+ $this->assertNull($user->addresses->get(0)->city);`
`962`	`962`	`$this->assertSame('Tokyo', $user->addresses->get(1)->city);`
`963`	`963`
`964`	`964`	`// Unset and reset property`
`@@ -967,7 +967,7 @@ public function testUnsetPropertyOnEmbed()`
`967`	`967`	`$user->addresses->get(1)->save();`
`968`	`968`
`969`	`969`	`$user = User::where('name', 'John Doe')->first();`
`970`		`- $this->assertSame(null, $user->addresses->get(0)->city);`
	`970`	`+ $this->assertNull($user->addresses->get(0)->city);`
`971`	`971`	`$this->assertSame('Kyoto', $user->addresses->get(1)->city);`
`972`	`972`	`}`
`973`	`973`	`}`