-
Notifications
You must be signed in to change notification settings - Fork 68
LG-5136: render functional components to get node text content #2908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d2cd17c
render named components to get node text
charcoalyy 7ab9537
check fc type
charcoalyy dd72f48
include parents if components are nested
charcoalyy c7ac75a
changeset
charcoalyy 73b0181
patch changeset
charcoalyy a0be473
specs
charcoalyy ce6ec8d
delete redundant changeset
charcoalyy 3973e40
nest functional components test
charcoalyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@leafygreen-ui/lib': patch | ||
--- | ||
|
||
Additional support for getting node text content from functional components. |
71 changes: 71 additions & 0 deletions
71
packages/lib/src/getNodeTextContent/getNodeTextContent.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
import React from 'react'; | ||
|
||
import getNodeTextContent from '.'; | ||
|
||
describe('packages/lib/src/getNodeTextContent', () => { | ||
describe('getNodeTextContent', () => { | ||
test('returns empty string for undefined node', () => { | ||
const result = getNodeTextContent(undefined); | ||
expect(result).toBe(''); | ||
}); | ||
|
||
test('returns correct text content for a string node', () => { | ||
const result = getNodeTextContent('leafy green'); | ||
expect(result).toBe('leafy green'); | ||
}); | ||
|
||
test('returns correct text content for a number node', () => { | ||
const result = getNodeTextContent(123); | ||
expect(result).toBe('123'); | ||
}); | ||
|
||
test('returns concatenated text content for an array of nodes', () => { | ||
const result = getNodeTextContent(['leafy', 'green', false]); | ||
expect(result).toBe('leafy green'); | ||
}); | ||
|
||
test('returns text content for intrinsic elements', () => { | ||
const element = React.createElement( | ||
'div', | ||
null, | ||
'leafy', | ||
React.createElement('span', null, 'green'), | ||
); | ||
const result = getNodeTextContent(element); | ||
expect(result).toBe('leafy green'); | ||
}); | ||
|
||
test('returns text content for functional components', () => { | ||
const FunctionalComponent = ({ title }: { title: string }) => { | ||
return React.createElement('h1', null, 'title: ', title); | ||
}; | ||
|
||
const element = React.createElement(FunctionalComponent, { | ||
title: 'leafy green', | ||
}); | ||
|
||
const result = getNodeTextContent(element); | ||
|
||
expect(result).toBe('title: leafy green'); | ||
}); | ||
|
||
test('returns text content for nested functional components', () => { | ||
const FunctionalComponent = ({ title }: { title: string }) => { | ||
return React.createElement( | ||
'div', | ||
null, | ||
'title: ', | ||
React.createElement('span', null, title), | ||
); | ||
}; | ||
|
||
const element = React.createElement(FunctionalComponent, { | ||
title: 'leafy green', | ||
}); | ||
|
||
const result = getNodeTextContent(element); | ||
|
||
expect(result).toBe('title: leafy green'); | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.