Skip to content

Commit da34ec9

Browse files
committed
CXX-495 fix serverGTE & serverLTE
1 parent 8e0ea48 commit da34ec9

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/mongo/client/examples/authTest.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <iostream>
2929
#include <cstdlib>
3030
#include <string>
31+
#include <utility>
3132

3233
using namespace mongo;
3334

@@ -39,7 +40,9 @@ bool serverLTE(DBClientBase* c, int major, int minor) {
3940
int serverMajor = version[0].Int();
4041
int serverMinor = version[1].Int();
4142

42-
return (serverMajor <= major && serverMinor <= minor);
43+
// std::pair uses lexicographic ordering
44+
return std::make_pair(serverMajor, serverMinor) <=
45+
std::make_pair(major, minor);
4346
}
4447

4548

src/mongo/integration/standalone/dbclient_test.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include <memory>
2222
#include <stdexcept>
2323
#include <string>
24+
#include <utility>
2425
#include <vector>
2526

2627
#include "mongo/stdx/functional.h"
@@ -65,7 +66,9 @@ namespace {
6566
int serverMajor = version[0].Int();
6667
int serverMinor = version[1].Int();
6768

68-
return (serverMajor >= major && serverMinor >= minor);
69+
// std::pair uses lexicographic ordering
70+
return std::make_pair(serverMajor, serverMinor) >=
71+
std::make_pair(major, minor);
6972
}
7073

7174
bool serverStorageEngine(DBClientBase& c, const StringData& engineName) {

0 commit comments

Comments
 (0)