EF-273: Pure refactoring (no behavior change) moving code out of MongoClientWrapper #252

ajcvickers · 2025-10-16T13:34:10Z

No description provided.

Copilot

Pull Request Overview

This PR refactors the MongoDB Entity Framework Core provider by moving database creation and index management logic from MongoClientWrapper to MongoDatabaseCreator. This is a pure refactoring that maintains existing behavior while improving the separation of concerns.

Key changes:

Moved database creation, deletion, and index management methods from IMongoClientWrapper/MongoClientWrapper to IMongoDatabaseCreator/MongoDatabaseCreator
Updated tests to use IMongoDatabaseCreator instead of IMongoClientWrapper for database operations
Simplified MongoDatabaseFacadeExtensions by adding a helper method to reduce code duplication

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
MongoDatabaseCreatorTests.cs	New test file with tests moved from MongoClientWrapperTests, updated to use IMongoDatabaseCreator
MongoClientWrapperTests.cs	Deleted - tests moved to MongoDatabaseCreatorTests
MongoDatabaseCreator.cs	Added database creation, deletion, and index management methods previously in MongoClientWrapper
MongoClientWrapper.cs	Removed database/index methods; exposed Client, Database, and DatabaseName as public properties
IMongoDatabaseCreator.cs	Added interface methods for database existence checks, index creation, and vector index operations
IMongoClientWrapper.cs	Removed database/index method signatures; added Client, Database, and DatabaseName property definitions
MongoDatabaseFacadeExtensions.cs	Simplified extension methods using new GetDatabaseCreator helper method

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs

tests/MongoDB.EntityFrameworkCore.FunctionalTests/Storage/MongoDatabaseCreatorTests.cs

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs

src/MongoDB.EntityFrameworkCore/Storage/MongoClientWrapper.cs

src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs

…oClientWrapper

ajcvickers · 2025-10-23T09:25:59Z

@damieng This is now rebased on your transaction changes and ready for review.

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-23T09:26:32Z

src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs

+    IDatabase database)
    : IMongoDatabaseCreator
 {


The removal of ICurrentDbContext currentDbContext parameter from the constructor could impact code that depends on this dependency. While the parameter was removed from the constructor signature, consider whether this dependency is needed elsewhere in the class or if there's alternative access to the context when required.

Suggested change

IDatabase database)

: IMongoDatabaseCreator

{

IDatabase database,

ICurrentDbContext currentDbContext)

: IMongoDatabaseCreator

{

private readonly ICurrentDbContext _currentDbContext = currentDbContext;

This is resolved by D.I. and should never be constructed directly.

src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs

Copilot · 2025-10-23T09:26:33Z

src/MongoDB.EntityFrameworkCore/Storage/MongoClientWrapper.cs

+    public IMongoClient Client => _client ??= GetOrCreateMongoClient(_options, _serviceProvider);

    /// <inheritdoc />
-    public async Task<IClientSessionHandle> StartSessionAsync(CancellationToken cancellationToken = default)
-        => await Client.StartSessionAsync(null, cancellationToken).ConfigureAwait(false);
+    public IMongoDatabase Database => _database ??= Client.GetDatabase(_databaseName);


Changing Client and Database from private to public properties is a breaking change that exposes internal implementation details. Consider the implications of making these publicly accessible, as it may allow consumers to bypass intended abstractions and directly interact with MongoDB primitives.

Documented as internal.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

damieng

Just need to address that copilot note about

Check warning on line 23 in src/MongoDB.EntityFrameworkCore/Metadata/MongoDatabaseCreationOptions.cs

Now referencing the old location for EnsureCreated.

damieng · 2025-10-23T16:53:05Z

src/MongoDB.EntityFrameworkCore/Storage/IMongoClientWrapper.cs

 public interface IMongoClientWrapper
 {
+    /// <summary>
+    /// The underlying <see cref="IMongoClient"/>. May cause the underlying client to be created.


Probably want to put the word "Accessing this" before "May"?

damieng · 2025-10-23T16:54:23Z

src/MongoDB.EntityFrameworkCore/Storage/IMongoDatabaseCreator.cs

+    Task<bool> DatabaseExistsAsync(CancellationToken cancellationToken = default);
+
+    /// <summary>
+    /// Creates an index in MongoDB based on the EF Core <see cref="IIndex"/> definition. No attempt is made to check that the index


Nit: Should probably be "Create" if the one above is "Determine"? Or "Creates" and "Determines" ?

ajcvickers requested a review from damieng October 16, 2025 13:34

ajcvickers requested a review from a team as a code owner October 16, 2025 13:34

Copilot AI review requested due to automatic review settings October 16, 2025 13:34

Copilot AI reviewed Oct 16, 2025

View reviewed changes

ajcvickers force-pushed the 1016_RedPanda branch from b751e43 to f1fb915 Compare October 16, 2025 13:37

ajcvickers requested a review from Copilot October 16, 2025 13:45

Copilot AI reviewed Oct 16, 2025

View reviewed changes

src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs Outdated Show resolved Hide resolved

src/MongoDB.EntityFrameworkCore/Storage/MongoClientWrapper.cs Show resolved Hide resolved

src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs Show resolved Hide resolved

EF-273: Pure refactoring (no behavior change) moving code out of Mong…

ee279c0

…oClientWrapper

ajcvickers force-pushed the 1016_RedPanda branch from 062ba0d to ee279c0 Compare October 23, 2025 09:23

ajcvickers requested a review from Copilot October 23, 2025 09:25

Copilot AI reviewed Oct 23, 2025

View reviewed changes

ajcvickers and others added 2 commits October 23, 2025 10:28

Update src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs

d440ef4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/MongoDB.EntityFrameworkCore/Storage/MongoDatabaseCreator.cs

37920ef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

damieng requested changes Oct 23, 2025

View reviewed changes

Review updates.

28debd1

ajcvickers requested a review from damieng October 24, 2025 10:49

damieng approved these changes Oct 24, 2025

View reviewed changes

ajcvickers merged commit 73c6b89 into main Oct 24, 2025
16 checks passed

Uh oh!

EF-273: Pure refactoring (no behavior change) moving code out of MongoClientWrapper #252

EF-273: Pure refactoring (no behavior change) moving code out of MongoClientWrapper #252

Uh oh!

Conversation

ajcvickers commented Oct 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ajcvickers commented Oct 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

ajcvickers Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

ajcvickers Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

damieng left a comment

Choose a reason for hiding this comment

Uh oh!

damieng Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

damieng Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants