-
Notifications
You must be signed in to change notification settings - Fork 915
GODRIVER-3102: Perf comp PR comment pipeline #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API Change ReportNo changes found! |
2bd1fec
to
187d8d0
Compare
187d8d0
to
6d8358c
Compare
👋 GoDriver PerformanceCommit SHA: ce710aeThe following benchmark tests for version 688bf0e5a985180007d026db had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! A few suggestions and questions.
🧪 Performance ResultsCommit SHA: 2355f33There were no significant changes to the performance to report for version 68937892f0691c0007204893.
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🔧 🔢
GODRIVER-3102
Summary
This is the pipeline for the perf comparison PR comment. It always outputs the results to the logs. If the commit being tested belongs to a PR, the pipeline will post a new comment or update an existing one on the PR with the performance comparison details.
Background & Motivation
This is so developers can see changes directly in the PR without needing to go through the Evergreen Parsley logs. Also, developers can proactively see how their commits affect performance before merging to mainline.