Skip to content

Commit 3413d85

Browse files
fhassakfhassak
authored andcommitted
Use the platform-specific line separator in Authorization header (#555)
JAVA-3782 Co-authored-by: fhassak <fares-externe.hassak@enedis.fr>
1 parent 4bd868b commit 3413d85

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

config/findbugs-exclude.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,4 +169,10 @@
169169
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
170170
</Match>
171171

172+
<!-- AWS use UNIX-style line endings -->
173+
<Match>
174+
<Class name="com.mongodb.internal.connection.AuthorizationHeader"/>
175+
<Bug pattern="VA_FORMAT_STRING_USES_NEWLINE"/>
176+
</Match>
177+
172178
</FindBugsFilter>

driver-core/src/main/com/mongodb/internal/connection/AuthorizationHeader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ static String getSignedHeaders(final Map<String, String> requestHeaders) {
115115

116116
static String getCanonicalHeaders(final Map<String, String> requestHeaders) {
117117
return requestHeaders.entrySet().stream()
118-
.map(kvp -> String.format("%s:%s%n", kvp.getKey().toLowerCase(), kvp.getValue().trim().replaceAll(" +", " ")))
118+
.map(kvp -> String.format("%s:%s\n", kvp.getKey().toLowerCase(), kvp.getValue().trim().replaceAll(" +", " ")))
119119
.sorted()
120120
.collect(Collectors.joining(""));
121121
}

0 commit comments

Comments
 (0)