use setters, rename privateLinks subcommand to use plurals, compare against empty string

Author: tcannon91

docs/command/atlas-streams-privateLink-create.txt renamed to docs/command/atlas-streams-privateLinks-create.txt

@@ -1,8 +1,8 @@
-.. _atlas-streams-privateLink-create:
+.. _atlas-streams-privateLinks-create:
 
-================================
-atlas streams privateLink create
-================================
+=================================
+atlas streams privateLinks create
+=================================
 
 .. default-domain:: mongodb
 
@@ -22,7 +22,7 @@ Syntax
 .. code-block::
    :caption: Command Syntax
 
-   atlas streams privateLink create [options]
+   atlas streams privateLinks create [options]
 
 .. Code end marker, please don't delete this comment
 

docs/command/atlas-streams-privateLink.txt renamed to docs/command/atlas-streams-privateLinks.txt

@@ -1,8 +1,8 @@
-.. _atlas-streams-privateLink:
+.. _atlas-streams-privateLinks:
 
-=========================
-atlas streams privateLink
-=========================
+==========================
+atlas streams privateLinks
+==========================
 
 .. default-domain:: mongodb
 
@@ -30,7 +30,7 @@ Options
    * - -h, --help
      - 
      - false
-     - help for privateLink
+     - help for privateLinks
 
 Inherited Options
 -----------------
@@ -51,11 +51,11 @@ Inherited Options
 Related Commands
 ----------------
 
-* :ref:`atlas-streams-privateLink-create` - Creates a PrivateLink endpoint that can be used as an Atlas Stream Processor connection.
+* :ref:`atlas-streams-privateLinks-create` - Creates a PrivateLink endpoint that can be used as an Atlas Stream Processor connection.
 
 
 .. toctree::
    :titlesonly:
 
-   create </command/atlas-streams-privateLink-create>
+   create </command/atlas-streams-privateLinks-create>
 

docs/command/atlas-streams.txt

@@ -53,13 +53,13 @@ Related Commands
 
 * :ref:`atlas-streams-connections` - Manage Atlas Stream Processing connections.
 * :ref:`atlas-streams-instances` - Manage Atlas Stream Processing instances.
-* :ref:`atlas-streams-privateLink` - Manage Atlas Stream Processing PrivateLink endpoints.
+* :ref:`atlas-streams-privateLinks` - Manage Atlas Stream Processing PrivateLink endpoints.
 
 
 .. toctree::
    :titlesonly:
 
    connections </command/atlas-streams-connections>
    instances </command/atlas-streams-instances>
-   privateLink </command/atlas-streams-privateLink>
+   privateLinks </command/atlas-streams-privateLinks>
 

internal/cli/streams/privatelink/create.go

@@ -48,7 +48,7 @@ func (opts *CreateOpts) Run() error {
 	}
 
 	// Remaining validation will be done by the API
-	if len(privateLinkEndpoint.GetProvider()) == 0 {
+	if privateLinkEndpoint.GetProvider() == "" {
 		return errors.New("provider missing")
 	}
 

internal/cli/streams/privatelink/create_test.go

@@ -30,15 +30,6 @@ import (
 const fileName = "test-privateLink.json"
 
 func TestCreateOpts_Run(t *testing.T) {
-	validPrivateLinkConfigFileContents := `
-		{
-			"provider": "Azure",
-			"region": "US_EAST_2",
-			"serviceEndpointId": "/subscriptions/fd01adff-b37e-4693-8497-83ecf183a145/resourceGroups/test-rg/providers/Microsoft.EventHub/namespaces/test-namespace",
-			"dnsDomain": "test-namespace.servicebus.windows.net"
-		}
-	`
-
 	testCases := []struct {
 		name         string
 		fileContents string
@@ -68,7 +59,7 @@ func TestCreateOpts_Run(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			fs := afero.NewMemMapFs()
 
-			if len(tc.fileContents) > 0 {
+			if tc.fileContents != "" {
 				require.NoError(t, afero.WriteFile(fs, fileName, []byte(tc.fileContents), 0600))
 			}
 
@@ -81,6 +72,15 @@ func TestCreateOpts_Run(t *testing.T) {
 		})
 	}
 
+	validPrivateLinkConfigFileContents := `
+		{
+			"provider": "Azure",
+			"region": "US_EAST_2",
+			"serviceEndpointId": "/subscriptions/fd01adff-b37e-4693-8497-83ecf183a145/resourceGroups/test-rg/providers/Microsoft.EventHub/namespaces/test-namespace",
+			"dnsDomain": "test-namespace.servicebus.windows.net"
+		}
+	`
+
 	t.Run("should call the store create privateLink method with the correct parameters", func(t *testing.T) {
 		fs := afero.NewMemMapFs()
 		require.NoError(t, afero.WriteFile(fs, fileName, []byte(validPrivateLinkConfigFileContents), 0600))
@@ -94,16 +94,11 @@ func TestCreateOpts_Run(t *testing.T) {
 			filename: fileName,
 		}
 
-		expectedProvider := "Azure"
-		expectedRegion := "US_EAST_2"
-		expectedServiceEndpointID := "/subscriptions/fd01adff-b37e-4693-8497-83ecf183a145/resourceGroups/test-rg/providers/Microsoft.EventHub/namespaces/test-namespace"
-		expectedDNSDomain := "test-namespace.servicebus.windows.net"
-
 		expected := atlasv2.NewStreamsPrivateLinkConnection()
-		expected.Provider = &expectedProvider
-		expected.Region = &expectedRegion
-		expected.ServiceEndpointId = &expectedServiceEndpointID
-		expected.DnsDomain = &expectedDNSDomain
+		expected.SetProvider("Azure")
+		expected.SetRegion("US_EAST_2")
+		expected.SetServiceEndpointId("/subscriptions/fd01adff-b37e-4693-8497-83ecf183a145/resourceGroups/test-rg/providers/Microsoft.EventHub/namespaces/test-namespace")
+		expected.SetDnsDomain("test-namespace.servicebus.windows.net")
 
 		mockStore.
 			EXPECT().

internal/cli/streams/privatelink/privatelink.go

@@ -24,7 +24,7 @@ import (
 var commandRoles = strings.Join([]string{"Project Owner", "Project Stream Processing Owner"}, ", ")
 
 func Builder() *cobra.Command {
-	const use = "privateLink"
+	const use = "privateLinks"
 	cmd := &cobra.Command{
 		Use:     use,
 		Aliases: cli.GenerateAliases(use),