fix: config describe prints secure properties with value redacted

Author: cveticm

internal/cli/config/describe.go

@@ -18,6 +18,7 @@ import (
 	"fmt"
 
 	"github.com/mongodb/atlas-cli-core/config"
+	"github.com/mongodb/atlas-cli-core/config/secure"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/require"
 	"github.com/spf13/cobra"
@@ -32,6 +33,47 @@ var descTemplate = `SETTING	VALUE{{ range $key, $value := . }}
 {{$key}}	{{$value}}{{end}}
 `
 
+const redacted = "redacted"
+
+// AddSecureProperties adds secure properties to the map with "redacted" value
+// if they are available in the config.
+func (opts *describeOpts) AddSecureProperties(m map[string]string) (map[string]string, error) {
+	// Check if secure storage is available
+	configStore, err := config.NewDefaultStore()
+	if err != nil {
+		return nil, err
+	}
+	if !configStore.IsSecure() {
+		return m, nil
+	}
+
+	// We are using a keyring client directly here to avoid printing env vars
+	secureKeyring := secure.NewDefaultKeyringClient()
+	// Service Account
+	if v, err := secureKeyring.Get(opts.name, "client_id"); err == nil && v != "" {
+		m["client_id"] = redacted
+	}
+	if v, err := secureKeyring.Get(opts.name, "client_secret"); err == nil && v != "" {
+		m["client_secret"] = redacted
+	}
+	// API Keys
+	if v, err := secureKeyring.Get(opts.name, "public_api_key"); err == nil && v != "" {
+		m["public_api_key"] = redacted
+	}
+	if v, err := secureKeyring.Get(opts.name, "private_api_key"); err == nil && v != "" {
+		m["private_api_key"] = redacted
+	}
+	// User Account
+	if v, err := secureKeyring.Get(opts.name, "access_token"); err == nil && v != "" {
+		m["access_token"] = redacted
+	}
+	if v, err := secureKeyring.Get(opts.name, "refresh_token"); err == nil && v != "" {
+		m["refresh_token"] = redacted
+	}
+
+	return m, nil
+}
+
 func (opts *describeOpts) Run() error {
 	if !config.Exists(opts.name) {
 		return fmt.Errorf("you don't have a profile named '%s'", opts.name)
@@ -41,7 +83,12 @@ func (opts *describeOpts) Run() error {
 		return err
 	}
 
-	return opts.Print(config.Map())
+	mapConfig, err := opts.AddSecureProperties(config.Map())
+	if err != nil {
+		return err
+	}
+
+	return opts.Print(mapConfig)
 }
 
 func DescribeBuilder() *cobra.Command {