use const

Author: blva

internal/cli/deployments/options/deployment_opts.go

@@ -45,24 +45,26 @@ import (
 const (
 	spinnerSpeed = 100 * time.Millisecond
 	// based on https://www.mongodb.com/docs/atlas/reference/api-resources-spec/v2/#tag/Clusters/operation/createCluster
-	clusterNamePattern = "^[a-zA-Z0-9][a-zA-Z0-9-]*$"
-	PausedState        = "PAUSED"
-	StoppedState       = "STOPPED"
-	IdleState          = "IDLE"
-	UpdatingState      = "UPDATING"
-	DeletingState      = "DELETING"
-	RestartingState    = "RESTARTING"
-	LocalCluster       = "local"
-	AtlasCluster       = "atlas"
-	CompassConnect     = "compass"
-	MongoshConnect     = "mongosh"
-	VsCodeConnect      = "vscode"
-	PromptTypeMessage  = "What type of deployment would you like to work with?"
-	MaxItemsPerPage    = 500
-	ContainerFilter    = "mongodb-atlas-local=container"
-	bytesInGb          = 1073741824
-	minimumRAM         = 2 * bytesInGb
-	minimumCores       = 2
+	clusterNamePattern      = "^[a-zA-Z0-9][a-zA-Z0-9-]*$"
+	PausedState             = "PAUSED"
+	StoppedState            = "STOPPED"
+	IdleState               = "IDLE"
+	UpdatingState           = "UPDATING"
+	DeletingState           = "DELETING"
+	RestartingState         = "RESTARTING"
+	LocalCluster            = "local"
+	AtlasCluster            = "atlas"
+	CompassConnect          = "compass"
+	MongoshConnect          = "mongosh"
+	VsCodeConnect           = "vscode"
+	PromptTypeMessage       = "What type of deployment would you like to work with?"
+	MaxItemsPerPage         = 500
+	ContainerFilter         = "mongodb-atlas-local=container"
+	ClusterWideScaling      = "CLUSTER_WIDE_SCALING"
+	IndependentShardScaling = "INDEPENDENT_SHARD_SCALING"
+	bytesInGb               = 1073741824
+	minimumRAM              = 2 * bytesInGb
+	minimumCores            = 2
 )
 
 var (

internal/cli/deployments/pause.go

@@ -108,15 +108,15 @@ func (opts *PauseOpts) RunAtlas() error {
 	defer opts.StopSpinner()
 
 	clusterAutoScalingConfig, err := opts.store.GetClusterAutoScalingConfig(opts.ConfigProjectID(), opts.DeploymentName)
-	if err != nil || clusterAutoScalingConfig.GetAutoScalingMode() == "CLUSTER_WIDE_SCALING" {
+	if err != nil || clusterAutoScalingConfig.GetAutoScalingMode() == options.ClusterWideScaling {
 		r, err := opts.store.PauseCluster(opts.ConfigProjectID(), opts.DeploymentName)
 		if err != nil {
 			return err
 		}
 		return opts.Print(r)
 	}
 
-	// If cluster is not CLUSTER_WIDE_SCALING, we use the latest API version
+	// If cluster is not cluster wide scaling, we use the latest API version
 	r, err := opts.store.PauseClusterLatest(opts.ConfigProjectID(), opts.DeploymentName)
 	if err != nil {
 		return err

internal/cli/deployments/pause_test.go

@@ -22,6 +22,7 @@ import (
 	"testing"
 
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli"
+	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/options"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/test/fixture"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/pointer"
 	"github.com/stretchr/testify/assert"
@@ -98,7 +99,7 @@ func TestPause_RunAtlas_clusterWideScaling(t *testing.T) {
 		GetClusterAutoScalingConfig(projectID, deploymentName).
 		Return(
 			&atlasv2.ClusterDescriptionAutoScalingModeConfiguration{
-				AutoScalingMode: pointer.Get("CLUSTER_WIDE_SCALING"),
+				AutoScalingMode: pointer.Get(options.ClusterWideScaling),
 			}, nil).
 		Times(1)
 
@@ -146,7 +147,7 @@ func TestPause_RunAtlas_independentShardScaling(t *testing.T) {
 		GetClusterAutoScalingConfig(projectID, deploymentName).
 		Return(
 			&atlasv2.ClusterDescriptionAutoScalingModeConfiguration{
-				AutoScalingMode: pointer.Get("INDEPENDENT_SHARD_SCALING"),
+				AutoScalingMode: pointer.Get(string(options.IndependentShardScaling)),
 			}, nil).
 		Times(1)
 

internal/cli/deployments/start.go

@@ -87,15 +87,15 @@ func (opts *StartOpts) RunAtlas() error {
 	defer opts.StopSpinner()
 
 	clusterAutoScalingConfig, err := opts.store.GetClusterAutoScalingConfig(opts.ConfigProjectID(), opts.DeploymentName)
-	if err != nil || clusterAutoScalingConfig.GetAutoScalingMode() == "CLUSTER_WIDE_SCALING" {
+	if err != nil || clusterAutoScalingConfig.GetAutoScalingMode() == options.ClusterWideScaling {
 		r, err := opts.store.StartCluster(opts.ConfigProjectID(), opts.DeploymentName)
 		if err != nil {
 			return err
 		}
 		return opts.Print(r)
 	}
 
-	// If cluster is not CLUSTER_WIDE_SCALING, we use the latest API version
+	// If cluster is not cluster wide scaling, we use the latest API version
 	r, err := opts.store.StartClusterLatest(opts.ConfigProjectID(), opts.DeploymentName)
 	if err != nil {
 		return err

internal/cli/deployments/start_test.go

@@ -22,6 +22,7 @@ import (
 	"testing"
 
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli"
+	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/options"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/cli/deployments/test/fixture"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/pointer"
 	"github.com/stretchr/testify/assert"
@@ -123,7 +124,7 @@ func TestStart_RunAtlas_clusterWideScaling(t *testing.T) {
 		GetClusterAutoScalingConfig(projectID, deploymentName).
 		Return(
 			&atlasv2.ClusterDescriptionAutoScalingModeConfiguration{
-				AutoScalingMode: pointer.Get("CLUSTER_WIDE_SCALING"),
+				AutoScalingMode: pointer.Get(string(options.ClusterWideScaling)),
 			}, nil).
 		Times(1)
 
@@ -169,7 +170,7 @@ func TestStart_RunAtlas_independentShardScaling(t *testing.T) {
 		GetClusterAutoScalingConfig(projectID, deploymentName).
 		Return(
 			&atlasv2.ClusterDescriptionAutoScalingModeConfiguration{
-				AutoScalingMode: pointer.Get("INDEPENDENT_SHARD_SCALING"),
+				AutoScalingMode: pointer.Get(string(options.IndependentShardScaling)),
 			}, nil).
 		Times(1)