Skip to content

Commit 989a101

Browse files
committed
fix test and add lint autofix items
1 parent 231beb6 commit 989a101

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

internal/cli/events/list_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package events
1818

1919
import (
20-
"strings"
2120
"testing"
2221

2322
"github.com/golang/mock/gomock"
@@ -124,7 +123,7 @@ func TestList_Run(t *testing.T) {
124123
if err == nil {
125124
t.Fatal("Run() expected an error, but got none")
126125
}
127-
assert.True(t, strings.Contains(err.Error(), "parsing time"))
126+
assert.Contains(t, err.Error(), "parsing time")
128127
})
129128
t.Run("for an project with invalid dates", func(t *testing.T) {
130129
listOpts := &ListOpts{
@@ -140,7 +139,7 @@ func TestList_Run(t *testing.T) {
140139
if err == nil {
141140
t.Fatal("Run() expected an error, but got none")
142141
}
143-
assert.True(t, strings.Contains(err.Error(), "parsing time"))
142+
assert.Contains(t, err.Error(), "parsing time")
144143
})
145144
}
146145

@@ -158,6 +157,6 @@ func TestParseDate(t *testing.T) {
158157
if err == nil {
159158
t.Fatalf("expected error from parseDate() but got none")
160159
}
161-
assert.True(t, strings.Contains(err.Error(), "parsing time"))
160+
assert.Contains(t, err.Error(), "parsing time")
162161
})
163162
}

internal/cli/events/projects_list_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package events
1818

1919
import (
20-
"strings"
2120
"testing"
2221

2322
"github.com/golang/mock/gomock"
@@ -87,5 +86,5 @@ func Test_projectListOpts_Run_WithInvalidDate(t *testing.T) {
8786
if err == nil {
8887
t.Fatal("Run() expected error")
8988
}
90-
assert.True(t, strings.Contains(err.Error(), "parsing time"))
89+
assert.Contains(t, err.Error(), "parsing time")
9190
}

test/e2e/atlas/auditing_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func TestAuditing(t *testing.T) {
6363
require.NoError(t, json.Unmarshal(resp, &setting), string(resp))
6464
assert.True(t, *setting.Enabled)
6565
assert.True(t, *setting.AuditAuthorizationSuccess)
66-
assert.Equal(t, "{\"atype\": \"authenticate\"}", *setting.AuditFilter)
66+
assert.JSONEq(t, "{\"atype\": \"authenticate\"}", *setting.AuditFilter)
6767
})
6868

6969
t.Run("Update via file", func(t *testing.T) {

test/e2e/atlas/streams_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ func TestStreams(t *testing.T) {
271271

272272
a := assert.New(t)
273273
a.Len(privateLinkEndpoints.GetResults(), 1)
274-
a.Equal("Azure", privateLinkEndpoints.GetResults()[0].GetProvider())
274+
a.Equal("AZURE", privateLinkEndpoints.GetResults()[0].GetProvider())
275275
a.Equal("US_EAST_2", privateLinkEndpoints.GetResults()[0].GetRegion())
276276
a.Equal("/subscriptions/fd01adff-b37e-4693-8497-83ecf183a145/resourceGroups/test-rg/providers/Microsoft.EventHub/namespaces/test-namespace", privateLinkEndpoints.GetResults()[0].GetServiceEndpointId())
277277
a.Equal("test-namespace.servicebus.windows.net", privateLinkEndpoints.GetResults()[0].GetDnsDomain())

0 commit comments

Comments
 (0)