CLOUDP-288306: Stop ignoring flags that were not supported (#3451)

blva · web-flow · commit d469444216cd · 2024-12-05T13:15:22.000Z
diff --git a/internal/cli/deployments/setup.go b/internal/cli/deployments/setup.go
@@ -632,9 +632,7 @@ func (opts *SetupOpts) runAtlas(ctx context.Context) error {
 	_, _ = log.Debugf("Removing flags and args from original args %s\n", os.Args)
 
 	flagstoRemove := map[string]string{
-		flag.TypeFlag:    "1",
-		flag.MDBVersion:  "1", // TODO: CLOUDP-200331
-		flag.ConnectWith: "1", // TODO: CLOUDP-199422
+		flag.TypeFlag: "1",
 	}
 
 	newArgs, err := workflows.RemoveFlagsAndArgs(flagstoRemove, map[string]bool{opts.DeploymentName: true}, os.Args)
diff --git a/test/e2e/atlas/deployments_atlas_test.go b/test/e2e/atlas/deployments_atlas_test.go
@@ -63,8 +63,10 @@ func TestDeploymentsAtlas(t *testing.T) {
 			"atlas",
 			"--tier",
 			"M10",
-			"--force",
+			"--mdbVersion",
+			"8.0",
 			"--skipMongosh",
+			"--force",
 			"--debug",
 			"--projectId", g.projectID,
 			"--username", dbUserUsername,

Original file line number	Diff line number	Diff line change
`@@ -632,9 +632,7 @@ func (opts *SetupOpts) runAtlas(ctx context.Context) error {`
`632`	`632`	`_, _ = log.Debugf("Removing flags and args from original args %s\n", os.Args)`
`633`	`633`
`634`	`634`	`flagstoRemove := map[string]string{`
`635`		`- flag.TypeFlag: "1",`
`636`		`- flag.MDBVersion: "1", // TODO: CLOUDP-200331`
`637`		`- flag.ConnectWith: "1", // TODO: CLOUDP-199422`
	`635`	`+ flag.TypeFlag: "1",`
`638`	`636`	`}`
`639`	`637`
`640`	`638`	`newArgs, err := workflows.RemoveFlagsAndArgs(flagstoRemove, map[string]bool{opts.DeploymentName: true}, os.Args)`