Skip to content

Commit fdbf545

Browse files
committed
fix
1 parent 79f579b commit fdbf545

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -129,15 +129,15 @@ Review and replace the atlas settings.
129129
```json
130130
{
131131
"go.testEnvVars": {
132-
"ATLAS_E2E_BINARY": "${workspaceFolder}/bin/atlas",
133-
"TEST_MODE": "live",
134-
"SNAPSHOTS_DIR": "${workspaceFolder}/test/e2e/testdata/.snapshots",
135-
"GOCOVERDIR": "${workspaceFolder}/cov",
136-
"MONGODB_ATLAS_SKIP_UPDATE_CHECK": "yes",
137-
"E2E_CLOUD_ROLE_ID": "<value here>",
138-
"E2E_TEST_BUCKET": "<value here>",
139-
"E2E_FLEX_INSTANCE_NAME": "<value here>",
140-
"IDENTITY_PROVIDER_ID": "<value here>"
132+
"ATLAS_E2E_BINARY": "${workspaceFolder}/bin/atlas", // required
133+
"SNAPSHOTS_DIR": "${workspaceFolder}/test/e2e/testdata/.snapshots", // required
134+
"TEST_MODE": "live", // optional default is 'live'
135+
"GOCOVERDIR": "${workspaceFolder}/cov", // optional used for coverage counting
136+
"MONGODB_ATLAS_SKIP_UPDATE_CHECK": "yes", // optional but recommended
137+
"E2E_CLOUD_ROLE_ID": "<value here>", // needed just for a few tests
138+
"E2E_TEST_BUCKET": "<value here>", // needed just for a few tests
139+
"E2E_FLEX_INSTANCE_NAME": "<value here>", // needed just for a few tests
140+
"IDENTITY_PROVIDER_ID": "<value here>" // needed just for a few tests
141141
}
142142
}
143143
```

test/internal/atlas_e2e_test_generator.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -689,8 +689,6 @@ func (g *AtlasE2ETestGenerator) storeSnapshot(r *http.Response) {
689689
func (g *AtlasE2ETestGenerator) readSnapshot(r *http.Request) *http.Response {
690690
g.t.Helper()
691691

692-
g.prepareRequest(r)
693-
694692
filename := g.snapshotName(r)
695693

696694
g.t.Logf("reading snapshot from %q", filename)

0 commit comments

Comments
 (0)