CLOUDP-275630: [AtlasCLI] NilPointer exception when downloading datafederation logs #3288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
approved these changes
Sep 26, 2024
Collaborator
andreaangiolillo
left a comment
andreaangiolillo
left a comment
There was a problem hiding this comment.
Comments are not blocking the PR. LGTM
| opts := &LogOpts{ | ||
| DownloaderOpts: cli.DownloaderOpts{ | ||
| Fs: afero.NewOsFs(), | ||
| Out: "-", // stdout |
Collaborator
There was a problem hiding this comment.
do we need this? isn't the default stout? I am asking because if the answer is no, we should update also the other commands that download logs
Member
Author
There was a problem hiding this comment.
I've copied this from internal/cli/deployments/logs.go.
It doesn't look like it's the default, the default is , not -.
I can create a followup PR to fix it everywhere
Member
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-275630