CLOUDP-278912: Export without Fed Auth #3329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
requested changes
Oct 16, 2024
| // Gets the FederationAuthSetting | ||
| federatedAuthentificationSetting, err := e.dataProvider.FederationSetting(&admin.GetFederationSettingsApiParams{OrgId: e.orgID}) | ||
| if err != nil { | ||
| if isAPIError(err, "RESOURCE_NOT_FOUND") { |
Contributor
There was a problem hiding this comment.
Redundant new function. Please use admin.IsErrorCode()
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
josvazg
force-pushed
the
CLOUDP-278912/fix-no-fed-auth-export
branch
from
e210fb7 to
755a8c8
Compare
helderjs
approved these changes
Oct 16, 2024
s-urbaniak
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-278912
The Atlas CLI Kubernetes config export should not fail when there is no Federated Auth configured.
Checklist
make fmtand formatted my codeFurther comments