Skip to content

Conversation

@josvazg
Copy link
Collaborator

@josvazg josvazg commented Oct 16, 2024

Proposed changes

Support a new flag for Kubernetes config generation so that resources that support independent usage are exporting with external ID references, instead of Kubernetes name references. In version 2.5 that means Atlas Database Users and Deployments will be exported with external project IDs when using the --independentResource flag like this:

$ atlas kubernetes config generate --projectId=<projectId> --independentResources

Users should extract the parts of the generated YAAMl definition that make sense for their use case.

Jira ticket: CLOUDP-278384

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@josvazg josvazg requested review from a team as code owners October 16, 2024 16:49
@josvazg josvazg marked this pull request as draft October 16, 2024 16:49
Base automatically changed from CLOUDP-278912/fix-no-fed-auth-export to master October 17, 2024 07:25
Copy link
Contributor

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a dedicated independent CRD e2e test.

@josvazg josvazg force-pushed the CLOUDP-278384/independent-id-exports branch 2 times, most recently from e4bcec8 to e4211d5 Compare October 29, 2024 08:08
@josvazg josvazg changed the title [WIP] CLOUDP-278384: Support Independent ID config generation CLOUDP-278384: Support Independent ID config generation Oct 29, 2024
@josvazg josvazg marked this pull request as ready for review October 29, 2024 08:14
@josvazg josvazg force-pushed the CLOUDP-278384/independent-id-exports branch 3 times, most recently from 7b960f2 to 9a110b1 Compare October 29, 2024 08:31
@josvazg josvazg requested a review from a team as a code owner October 29, 2024 08:31
@github-actions github-actions bot added the need-doc-review Improvements or additions to documentation, will be reviewed by the docs team label Oct 29, 2024
@github-actions
Copy link
Contributor

APIx Bot :bowtie:: a message has been sent to Docs Slack channel 🚀.

@josvazg
Copy link
Collaborator Author

josvazg commented Oct 29, 2024

I'm missing a dedicated independent CRD e2e test.

Look at TestExportIndependentOrNot

✅ Test passed:

% make build && export ATLAS_E2E_BINARY=$(pwd)/bin/atlas && go test --tags="e2e" -race -cover -count=1 -coverprofile coverage.out ./test/e2e/atlas/... -run TestExportIndependentOrNot
==> Building atlas binary
go build -ldflags "-s -w -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.GitCommit=9a110b135f90bf87582032b794ce54a363f8ede5 -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.Version=1.29.0-50-g9a110b135"  -o ./bin/atlas ./cmd/atlas
ok  	github.com/mongodb/mongodb-atlas-cli/atlascli/test/e2e/atlas	87.788s	coverage: [no statements]

@josvazg josvazg force-pushed the CLOUDP-278384/independent-id-exports branch from 9a110b1 to 03ed0fd Compare October 29, 2024 09:53
helderjs
helderjs previously approved these changes Oct 29, 2024
Copy link
Contributor

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

igor-karpukhin
igor-karpukhin previously approved these changes Oct 29, 2024
@josvazg josvazg dismissed stale reviews from igor-karpukhin and helderjs via 51155a0 October 29, 2024 11:06
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
@josvazg josvazg force-pushed the CLOUDP-278384/independent-id-exports branch from 51155a0 to acff5da Compare October 29, 2024 11:08
lmkerbey-mdb
lmkerbey-mdb previously approved these changes Oct 29, 2024
Copy link
Contributor

@lmkerbey-mdb lmkerbey-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
@josvazg josvazg force-pushed the CLOUDP-278384/independent-id-exports branch from 4d27e98 to 95d92ed Compare October 30, 2024 13:34
@josvazg josvazg merged commit 638c43f into master Oct 30, 2024
21 checks passed
@josvazg josvazg deleted the CLOUDP-278384/independent-id-exports branch October 30, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

atlascli need-doc-review Improvements or additions to documentation, will be reviewed by the docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants