-
Notifications
You must be signed in to change notification settings - Fork 88
CLOUDP-278384: Support Independent ID config generation #3330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
helderjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing a dedicated independent CRD e2e test.
e4bcec8 to
e4211d5
Compare
7b960f2 to
9a110b1
Compare
|
APIx Bot |
Look at ✅ Test passed: % make build && export ATLAS_E2E_BINARY=$(pwd)/bin/atlas && go test --tags="e2e" -race -cover -count=1 -coverprofile coverage.out ./test/e2e/atlas/... -run TestExportIndependentOrNot
==> Building atlas binary
go build -ldflags "-s -w -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.GitCommit=9a110b135f90bf87582032b794ce54a363f8ede5 -X github.com/mongodb/mongodb-atlas-cli/atlascli/internal/version.Version=1.29.0-50-g9a110b135" -o ./bin/atlas ./cmd/atlas
ok github.com/mongodb/mongodb-atlas-cli/atlascli/test/e2e/atlas 87.788s coverage: [no statements] |
9a110b1 to
03ed0fd
Compare
helderjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is happy
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
51155a0 to
acff5da
Compare
lmkerbey-mdb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
4d27e98 to
95d92ed
Compare
Proposed changes
Support a new flag for Kubernetes config generation so that resources that support independent usage are exporting with external ID references, instead of Kubernetes name references. In version 2.5 that means Atlas Database Users and Deployments will be exported with external project IDs when using the
--independentResourceflag like this:Users should extract the parts of the generated YAAMl definition that make sense for their use case.
Jira ticket: CLOUDP-278384
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments