Skip to content

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Oct 31, 2024

Proposed changes

Quote connection string

Jira ticket: CLOUDP-200470

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

Expected change in output

[Default Settings]
Deployment Name   local491
MongoDB Version   8.0

Creating your cluster local491 [this might take several minutes]
1/3: Starting your local environment...
2/3: Downloading the latest MongoDB image to your local environment...
3/3: Creating your deployment local491...
Deployment created!
- Connection string: mongodb://localhost:57981/?directConnection=true
+ Connection string: "mongodb://localhost:57981/?directConnection=true"

connection skipped

@fmenezes fmenezes marked this pull request as ready for review October 31, 2024 13:45
@fmenezes fmenezes requested a review from a team as a code owner October 31, 2024 13:45
@fmenezes fmenezes enabled auto-merge (squash) October 31, 2024 13:47
@fmenezes fmenezes merged commit bc1ed77 into master Oct 31, 2024
21 of 22 checks passed
@fmenezes fmenezes deleted the CLOUDP-200470 branch October 31, 2024 13:56

_, _ = log.Warningln("Deployment created!")
_, _ = fmt.Fprintf(opts.OutWriter, "Connection string: %s\n", cs)
_, _ = fmt.Fprintf(opts.OutWriter, `Connection string: "%s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

_, _ = fmt.Fprintf(opts.OutWriter, `Connection string: %q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants