Skip to content

chore: make opts a receiver for validation functions #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

chore: make opts a receiver for validation functions #3570

merged 2 commits into from
Jan 21, 2025

Conversation

@gssbzn
Copy link
Contributor

@gssbzn gssbzn commented Jan 21, 2025

Proposed changes

Had this staged, mainly make the validation methods take the opts as a receiver instead of an arg since it makes more sense that way

@apix-bot
Copy link
Contributor

apix-bot bot commented Jan 21, 2025

Coverage Report 📈

Branch Commit Coverage
master 547147a 38.8%
alert-validator b83aa31 38.8%
Difference 0%

@gssbzn gssbzn marked this pull request as ready for review January 21, 2025 11:48
@gssbzn gssbzn requested a review from a team as a code owner January 21, 2025 11:48
@gssbzn gssbzn merged commit 5dd3d1f into master Jan 21, 2025
23 checks passed
@gssbzn gssbzn deleted the alert-validator branch January 21, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gssbzn @jeroenvervaeke