Skip to content

CLOUDP-296190: [Flex Clusters] --targetProjectId is not handled properly #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

CLOUDP-296190: [Flex Clusters] --targetProjectId is not handled properly #3572

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea6fe9
Flex: Fix bug with restore jobs, TargetProjectID is optional
jeroenvervaeke Jan 22, 2025
72c9ab9
fix linter error
jeroenvervaeke Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions internal/cli/backup/restores/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,17 @@ func (opts *StartOpts) Run() error {
}

func (opts *StartOpts) newFlexBackupRestoreJobCreate() *admin.FlexBackupRestoreJobCreate20241113 {
return &admin.FlexBackupRestoreJobCreate20241113{
request := &admin.FlexBackupRestoreJobCreate20241113{
SnapshotId: opts.snapshotID,
TargetDeploymentItemName: opts.targetClusterName,
TargetProjectId: &opts.targetProjectID,
InstanceName: &opts.clusterName,
}

if opts.targetProjectID != "" {
request.TargetProjectId = &opts.targetProjectID
}

return request
}

func (opts *StartOpts) newCloudProviderSnapshotRestoreJob() *admin.DiskBackupSnapshotRestoreJob {
Expand Down
Loading