CLOUDP-297921: Remove k8s libs and vars #3593
Conversation
| - "golang.org*" | ||
| kubernetes: | ||
| patterns: | ||
| - "*k8s.io*" |
There was a problem hiding this comment.
Noting that I did not remove the kubernetes group from mongocli-master dependabot actions (here)
| - pkg: github.com/mongodb/mongodb-atlas-kubernetes/v2/api | ||
| alias: akoapi | ||
| - pkg: github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1 | ||
| alias: akov2 | ||
| - pkg: github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/common | ||
| alias: akov2common | ||
| - pkg: github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/provider | ||
| alias: akov2provider | ||
| - pkg: github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/status | ||
| alias: akov2status | ||
| - pkg: github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/project | ||
| alias: akov2project | ||
| - pkg: k8s.io/apimachinery/pkg/apis/meta/v1 | ||
| alias: metav1 | ||
| - pkg: k8s.io/api/apps/v1 | ||
| alias: appsv1 | ||
| - pkg: k8s.io/api/core/v1 | ||
| alias: corev1 | ||
| - pkg: k8s.io/api/rbac/v1 | ||
| alias: rbacv1 | ||
| - pkg: k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1 | ||
| alias: apiextensionsv1 | ||
| - pkg: k8s.io/apiserver/pkg/storage/names | ||
| alias: k8snames |
There was a problem hiding this comment.
All libraries here are no longer present in the codebase after k8s command migration
| @echo "==> Running E2E tests..." | ||
| GOCOVERDIR=$(GOCOVERDIR) $(TEST_CMD) -v -p 1 -parallel $(E2E_PARALLEL) -v -timeout $(E2E_TIMEOUT) -tags="$(E2E_TAGS)" ./test/e2e... $(E2E_EXTRA_ARGS) | ||
|
|
||
| .PHONY: fuzz-normalizer-test |
There was a problem hiding this comment.
Fuzz test only used by k8s tests
| "go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc": "apix-2", | ||
| "go.opentelemetry.io/otel/sdk": "apix-2", | ||
| "go.opentelemetry.io/otel/trace": "apix-2", | ||
| "golang.org/x/exp": "atlas_kubernetes_team", |
There was a problem hiding this comment.
Library is still used so moving ownership to apix-2
| | `kubernetes config generate` | Y | Y | | ||
| | `kubernetes config apply` | Y | Y | | ||
| | `kubernetes operator install` | Y | Y | |
There was a problem hiding this comment.
Curious to hear opinions on this change.
These entries could be kept and instead marked as 'N' in both E2E and Atlas. Should 'kubernetes' (and first-class plugins in general) be marked 'N' in Atlas as it is not in the codebase but is E2E tested in Atlas?
There was a problem hiding this comment.
If we have a test to install the plugin on CLI, than this makes sense to me, if not I would mark as N
There was a problem hiding this comment.
@fmenezes to clarify, you are saying it makes sense to leave it as is(i.e. | `kubernetes` | Y | Y | - Yes there is an E2E test in Atlas, Yes it is in Atlas) or my suggestion to mark it | `kubernetes` | Y | N | (- Yes there is an E2E test in Atlas, No it's not in Atlas)?
Proposed changes
Tidies k8s dev branch by:
Jira ticket: CLOUDP-297921
Checklist
make fmtand formatted my codeFurther comments