Skip to content

CLOUDP-295930: Update help docs for clusters for shimming logic #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

CLOUDP-295930: Update help docs for clusters for shimming logic #3597

merged 2 commits into from
Feb 5, 2025
+9 −1

Conversation

@jeroenvervaeke
Copy link
Member

Proposed changes

Improved:

  • Help message when using --tier on atlas cluster create and atlas cluster update
  • Improved docs for both pages too.

Jira ticket: CLOUDP-295930

@jeroenvervaeke jeroenvervaeke requested review from a team as code owners January 31, 2025 14:47
@github-actions github-actions bot added need-doc-review Improvements or additions to documentation, will be reviewed by the docs team atlascli labels Jan 31, 2025
@github-actions
Copy link
Contributor

APIx Bot :bowtie:: a message has been sent to Docs Slack channel 🚀.

andreaangiolillo
andreaangiolillo previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JuliaMongo
JuliaMongo previously requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@JuliaMongo JuliaMongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review with Anurag Kadasne. He needs access to the repo.
Please add the dochub link to all places, not just one.
Please remove the word timeline from the description of the link. We don't share the timeline publicly.

@apix-bot
Copy link
Contributor

apix-bot bot commented Jan 31, 2025

Coverage Report 📈

Branch Commit Coverage
master 6e2fcbc 39.1%
CLOUDP-295930 c9cf81d 39.1%
Difference 0%

andreaangiolillo
andreaangiolillo approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo dismissed JuliaMongo’s stale review January 31, 2025 16:24

Comments were addressed.

JuliaMongo
JuliaMongo approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@JuliaMongo JuliaMongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finalized with Anurag and approved.

@jeroenvervaeke jeroenvervaeke merged commit 69e2951 into master Feb 5, 2025
23 checks passed
@jeroenvervaeke jeroenvervaeke deleted the CLOUDP-295930 branch February 5, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@JuliaMongo JuliaMongo JuliaMongo approved these changes

Assignees

No one assigned

Labels

atlascli need-doc-review Improvements or additions to documentation, will be reviewed by the docs team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeroenvervaeke @andreaangiolillo @JuliaMongo