CLOUDP-291620: Add streams privateLink create command #3616
Conversation
tcannon91
force-pushed
the
CLOUDP-291620
branch
2 times, most recently
from
19189fd to
b450eae
Compare
tcannon91
force-pushed
the
CLOUDP-291620
branch
from
b450eae to
7019e36
Compare
tcannon91
dismissed stale reviews from carriecwk and jasonrydberg
via
5ec1d8f
| Times(1) | ||
|
|
||
| require.NoError(t, createOpts.Run()) | ||
| assert.Equal(t, "Atlas Stream Processing PrivateLink endpoint "+expectedInterfaceEndpointID+" created.\n", buf.String()) |
There was a problem hiding this comment.
this can for sure be part of the test matrix
There was a problem hiding this comment.
I am running into issues bringing this up into the test matrix function because the mock store does not get called so the assertions (even though they are weak and I don't care about them) fail, but I need them to force a store return value that I can consistently assert against for this string where this comment is. Adding conditionals to my test matrix to have different branches within my test defeats the purpose of a test matrix in my opinion so I think leaving this as a separate test makes the most sense.
There was a problem hiding this comment.
yeah if too hard no worries but was worth flagging that output check could be part of a matrix
…gainst empty string
4 participants
Proposed changes
Add the ability for users to create PrivateLink endpoints that can be used by atlas stream processors. The configuration for the PrivateLink endpoint will be managed in a .json file, which will be read into the configuration struct.
Jira ticket: CLOUDP-291620
Checklist
make fmtand formatted my codeFurther comments