Skip to content

CLOUDP-299959: sunset apis should be ignored from autogenerated commands #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

CLOUDP-299959: sunset apis should be ignored from autogenerated commands #3631

merged 1 commit into from
Feb 11, 2025

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Feb 11, 2025 •
edited
Loading

Proposed changes

sunset apis should be ignored from autogenerated commands

Jira ticket: CLOUDP-299959

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review February 11, 2025 15:47
@fmenezes fmenezes requested a review from a team as a code owner February 11, 2025 15:47
andreaangiolillo
andreaangiolillo approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo changed the title CLOUDP-299959 sunset apis should be ignored from autogenerated commands CLOUDP-299959: sunset apis should be ignored from autogenerated commands Feb 11, 2025
@fmenezes fmenezes merged commit 368055f into master Feb 11, 2025
23 of 24 checks passed
@fmenezes fmenezes deleted the CLOUDP-299959 branch February 11, 2025 15:58
@apix-bot
Copy link
Contributor

apix-bot bot commented Feb 11, 2025

Coverage Report 📉

Branch Commit Coverage
master 0b2890e 39.4%
CLOUDP-299959 645a5f6 39.1%
Difference -.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

+1 more reviewer

@gssbzn gssbzn gssbzn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmenezes @gssbzn @andreaangiolillo