Skip to content

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Feb 11, 2025

Proposed changes

Annotate current watchers

Jira ticket: CLOUDP-297413

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

Watchers that were not added:

  • /api/atlas/v2/groups/{groupId}/serverless/{clusterName}/backup/restoreJobs apis: complexity on evaluation (ref)
  • /api/atlas/v2/groups/{groupId}/peers: complexity on choosing statusName or status (ref)
  • /api/atlas/v2/groups/{groupId}/pipelines/{pipelineName}/runs: not found which "main command" would hold --watch

@fmenezes fmenezes marked this pull request as ready for review February 12, 2025 18:41
@fmenezes fmenezes requested a review from a team as a code owner February 12, 2025 18:41
@fmenezes fmenezes enabled auto-merge (squash) February 12, 2025 18:47
- cron: 30 8 * * TUE
workflow_dispatch:
jobs:
update-sdk:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by

@fmenezes fmenezes merged commit bd8a63c into master Feb 12, 2025
20 of 21 checks passed
@fmenezes fmenezes deleted the CLOUDP-297413 branch February 12, 2025 19:00
@apix-bot
Copy link
Contributor

apix-bot bot commented Feb 12, 2025

Coverage Report 📈

Branch Commit Coverage
master 3f5d990 39.4%
CLOUDP-297413 a869ffa 39.4%
Difference 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants