CLOUDP-299959 fix x-sunset should be defined at responses #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Helper function to add content type to version map. | ||
| func addContentTypeToVersion(versionedContentType string, versionsMap map[string]*api.Version, isRequest bool) error { | ||
| func addContentTypeToVersion(versionedContentType string, versionsMap map[string]*api.Version, isRequest bool, sunset *time.Time) error { |
There was a problem hiding this comment.
[Curious] Could you direct me to where we use versionsMap to generate the commands?
There was a problem hiding this comment.
operationToCommand calls buildVersions and there we check if no versions are found we skip the operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix x-sunset should be defined at responses
Jira ticket: CLOUDP-299959
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments