CLOUDP-293194: Merge plugin shift into AtlasCLI #3636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
changed the title
blva
force-pushed
the
CLOUDP-260713_k8s_plugin
branch
3 times, most recently
from
40be12a to
cf2467c
Compare
blva
force-pushed
the
CLOUDP-260713_k8s_plugin
branch
from
cf2467c to
ed9bb6f
Compare
Contributor
fmenezes
approved these changes
Feb 12, 2025
Collaborator
|
nit: I would have used jira https://jira.mongodb.org/browse/CLOUDP-293194 |
blva
changed the title
github-actions
bot
added
the
need-doc-review
Contributor
|
APIx Bot |
: a message has been sent to Docs Slack channel 🚀.
cveticm
approved these changes
Feb 12, 2025
Collaborator
|
Note: as fuzz tests are removed in this PR, it should be removed from required tasks |
gssbzn
reviewed
Feb 13, 2025
| github.com/BurntSushi/toml v1.4.0 // indirect | ||
| github.com/PaesslerAG/gval v1.0.0 // indirect | ||
| github.com/ProtonMail/go-crypto v0.0.0-20230217124315-7d5c6f04bbb8 // indirect | ||
| github.com/ProtonMail/go-crypto v0.0.0-20230217124315-7d5c6f04bbb8 |
Contributor
There was a problem hiding this comment.
why did you remove the // indirect directive?
gssbzn
reviewed
Feb 13, 2025
Comment on lines
+65
to
+70
| require ( | ||
| github.com/go-openapi/jsonpointer v0.21.0 // indirect | ||
| github.com/go-openapi/swag v0.23.0 // indirect | ||
| github.com/josharian/intern v1.0.0 // indirect | ||
| github.com/mailru/easyjson v0.7.7 // indirect | ||
| github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 // indirect |
Contributor
There was a problem hiding this comment.
why did you group these separate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
move kubernetes commands out of altascli codebase into a plugin
Jira ticket: CLOUDP-293194
Checklist
make fmtand formatted my codeFurther comments