Skip to content

fix: update event type #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: update event type #3651

merged 1 commit into from
Feb 13, 2025

Conversation

@blva
Copy link
Collaborator

@blva blva commented Feb 13, 2025 •
edited
Loading

Proposed changes

Updating to match mongodb/atlas-cli-plugin-kubernetes#37

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review February 13, 2025 15:02
@blva blva requested a review from a team as a code owner February 13, 2025 15:02
@apix-bot
Copy link
Contributor

apix-bot bot commented Feb 13, 2025

Coverage Report 📈

Branch Commit Coverage
master 5a53d76 37.7%
fix-event-type 0008bc3 37.7%
Difference 0%

@blva blva merged commit ad87d1c into master Feb 13, 2025
23 of 24 checks passed
@blva blva deleted the fix-event-type branch February 13, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blva @andreaangiolillo