Skip to content

CLOUDP-300050: validate spec on update PRs #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025
Merged

CLOUDP-300050: validate spec on update PRs #3654

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b05a53d
added watcher settings validation, fixed existing watchers, fix param…
jeroenvervaeke Feb 14, 2025
cbaf77c
Merge branch 'master' into CLOUDP-300050
jeroenvervaeke Feb 14, 2025
aef5fc4
fix linting
jeroenvervaeke Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 72 additions & 35 deletions internal/api/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getAtlasSearchDeployment`,
Version: `2024-05-30`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -1644,7 +1645,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getAtlasSearchDeployment`,
Version: `2024-05-30`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -2559,7 +2561,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getAtlasSearchDeployment`,
Version: `2024-05-30`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -3094,7 +3097,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getBackupExportJob`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`exportId`: `body:$.id`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -3521,7 +3526,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getReplicaSetBackup`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
`snapshotId`: `input:snapshotId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -3670,7 +3677,7 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getDataProtectionSettings`,
Version: `2023-10-01`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -5076,7 +5083,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getReplicaSetBackup`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
`snapshotId`: `body:$.id`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -5237,7 +5246,7 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getDataProtectionSettings`,
Version: `2023-10-01`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -5332,7 +5341,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getReplicaSetBackup`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
`snapshotId`: `input:snapshotId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -6476,9 +6487,10 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getCluster`,
Version: `2024-10-23`,
Version: `2024-08-05`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `body:$.name`,
`groupId`: `body:$.groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -6581,9 +6593,10 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getCluster`,
Version: `2024-10-23`,
Version: `2024-08-05`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -7305,7 +7318,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getSampleDatasetLoadStatus`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`sampleDatasetId`: `body:$.id`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -7689,9 +7703,10 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getCluster`,
Version: `2024-10-23`,
Version: `2024-08-05`,
Params: map[string]string{
`orgId`: `123`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -9973,7 +9988,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getPipeline`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`pipelineName`: `body:$.name`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -10048,7 +10064,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getPipeline`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`pipelineName`: `input:pipelineName`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -10879,7 +10896,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getPipeline`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`pipelineName`: `input:pipelineName`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -13410,7 +13428,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getFlexCluster`,
Version: `2024-11-13`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`name`: `body:$.name`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -13496,7 +13515,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getFlexCluster`,
Version: `2024-11-13`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`name`: `input:name`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -13733,7 +13753,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getFlexCluster`,
Version: `2024-11-13`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`name`: `input:name`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -13882,7 +13903,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getFlexBackupRestoreJob`,
Version: `2024-11-13`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`name`: `input:name`,
`restoreJobId`: `body:$.id`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -15578,7 +15601,8 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getLdapConfigurationStatus`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`requestId`: `body:$.requestId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -20153,7 +20177,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getOnlineArchive`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`archiveId`: `body:$.id`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -20252,7 +20278,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getOnlineArchive`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`archiveId`: `input:archiveId`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -20607,7 +20635,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getOnlineArchive`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`archiveId`: `input:archiveId`,
`clusterName`: `input:clusterName`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -22898,7 +22928,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getPrivateEndpointService`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`cloudProvider`: `body:$.cloudProvider`,
`endpointServiceId`: `body:$.id`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -23082,7 +23114,9 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
OperationID: `getPrivateEndpointService`,
Version: `2023-01-01`,
Params: map[string]string{
`orgId`: `123`,
`cloudProvider`: `body:$.cloudProvider`,
`endpointServiceId`: `body:$.id`,
`groupId`: `input:groupId`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -27478,9 +27512,10 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getFlexCluster`,
Version: `2023-01-01`,
Version: `2024-11-13`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`name`: `body:$.name`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -27566,9 +27601,10 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getFlexCluster`,
Version: `2023-01-01`,
Version: `2024-11-13`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`name`: `input:name`,
},
},
Expect: &WatcherExpectProperties{
Expand Down Expand Up @@ -27812,9 +27848,10 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getFlexCluster`,
Version: `2023-01-01`,
Version: `2024-11-13`,
Params: map[string]string{
`orgId`: `123`,
`groupId`: `input:groupId`,
`name`: `input:name`,
},
},
Expect: &WatcherExpectProperties{
Expand Down
18 changes: 0 additions & 18 deletions tools/api-generator/.snapshots/04-spec-with-overrides.yaml.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,24 +95,6 @@ var Commands = GroupedAndSortedCommands{
},
},
},
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getCluster`,
Version: `2023-02-01`,
Params: map[string]string{
`orgId`: `123`,
},
},
Expect: &WatcherExpectProperties{
HTTPCode: 200, //nolint
Match: &WatcherMatchProperties{
Path: `$.stateName`,
Values: []string{
`IDLE`,
},
},
},
},
},
},
},
Expand Down
10 changes: 0 additions & 10 deletions tools/api-generator/.snapshots/06-spec-with-cli-specific-extensions.yaml.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,16 +101,6 @@ NOTE: Groups and projects are synonymous terms. Your group id is the same as you
},
},
},
Watcher: &WatcherProperties{
Get: WatcherGetProperties{
OperationID: `getCluster`,
Version: ``,
Params: map[string]string{
`orgId`: `123`,
},
},
Expect: nil,
},
},
},
},
Expand Down
Loading
Loading