CLOUDP-300869: Upgrade golangci to v1.64.5 #3656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Feb 17, 2025
gssbzn
reviewed
Feb 17, 2025
| assert.True(t, *setting.Enabled) | ||
| assert.True(t, *setting.AuditAuthorizationSuccess) | ||
| assert.Equal(t, "{\"atype\": \"authenticate\"}", *setting.AuditFilter) | ||
| assert.JSONEq(t, "{\"atype\": \"authenticate\"}", *setting.AuditFilter) |
Contributor
|
Coverage Report 📈
|
Contributor
|
evergreen keep-definitions |
gssbzn
approved these changes
Feb 18, 2025
Contributor
gssbzn
left a comment
gssbzn
left a comment
There was a problem hiding this comment.
since you are updating go we depend on it being available on evergreen, adding the packaging tests which uses other vms like windows to make sure go1.24 is available, good to merge if packaging passes
blva
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-300869