Skip to content

fix: Flex Backup Tests #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix: Flex Backup Tests #3657

merged 1 commit into from
Feb 17, 2025

Conversation

@roothorp
Copy link
Collaborator

@roothorp roothorp commented Feb 17, 2025

Proposed changes

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@apix-bot
Copy link
Contributor

apix-bot bot commented Feb 17, 2025

Coverage Report 📈

Branch Commit Coverage
master ab76bb3 37.8%
flex-backup-fix ca86e22 37.8%
Difference 0%

@roothorp roothorp marked this pull request as ready for review February 17, 2025 13:55
@roothorp roothorp requested a review from a team as a code owner February 17, 2025 13:55
blva
blva approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo changed the title Fix Flex Backup Tests fix: Flex Backup Tests Feb 17, 2025
andreaangiolillo
andreaangiolillo approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@fmenezes fmenezes merged commit 924675d into master Feb 17, 2025
24 of 26 checks passed
@fmenezes fmenezes deleted the flex-backup-fix branch February 17, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@blva blva blva approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@roothorp @andreaangiolillo @blva @fmenezes