Skip to content

fix: revert all backup changes #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: revert all backup changes #3665

merged 2 commits into from
Feb 18, 2025

Conversation

@blva
Copy link
Collaborator

@blva blva commented Feb 18, 2025 •
edited
Loading

Proposed changes

fixes backup tests back to using clusterName as it's expected everywhere

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review February 18, 2025 11:01
@blva blva requested a review from a team as a code owner February 18, 2025 11:01
@apix-bot
Copy link
Contributor

apix-bot bot commented Feb 18, 2025

Coverage Report 📈

Branch Commit Coverage
master 39f5636 37.8%
backup_flex e5aef2b 37.8%
Difference 0%

cveticm
cveticm approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blva blva merged commit 4db71ee into master Feb 18, 2025
24 checks passed
@blva blva deleted the backup_flex branch February 18, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cveticm cveticm cveticm approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blva @cveticm