task: improve autogeneration integration with other tools #3706
Conversation
| // | ||
| // This code was autogenerated using `make gen-L1-commands` | ||
|
|
||
| // Code generated using `make gen-api-commands`. DO NOT EDIT. |
There was a problem hiding this comment.
GH will consider any file with // Code generated ... as auto generated
Intellij will show a warning when opening files with DO NOT EDIT.
| @@ -1,4 +1,5 @@ | |||
| {{- /* Template for generating L1 commands */ -}} | |||
| {{- /*gotype: github.com/mongodb/mongodb-atlas-cli/atlascli/internal/api.GroupedAndSortedCommands */ -}} | |||
There was a problem hiding this comment.
this file has a year that auto-updates which means tests will start failing on January next year
There was a problem hiding this comment.
yeap, we will need to regenerate the snapshots once a year, I think that is ok, better the write 2024 like before
There was a problem hiding this comment.
copyright years don't need to be updated FYI, we also skip the whole copyright header on some autogenerated files like mocks and we tell the checks to ignore those folders, just things to consider if this becomes a problem
There was a problem hiding this comment.
on old files is ok, but generating new files on old dates seems weird.
Proposed changes
Improve the generate code to leverage tools conventions for detecting autogenerated code
As a side note I find a bit confusing I need to run
make bin/api-generatorif I do changes to the generation code since make will cache the bin and won't try to rebuild, I wonder why we went with a pre-built binary overgo run