Skip to content

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Mar 10, 2025

Proposed changes

followup from #3711, moving tools under tools/cmd and shared code into tools/internal

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review March 10, 2025 19:06
@fmenezes fmenezes requested a review from a team as a code owner March 10, 2025 19:06
@github-actions
Copy link
Contributor

Coverage Report 📉

Branch Commit Coverage
master 415526a 37.9%
chore_move_tools_to_cmd 99d96c7 %
Difference -37.9%

Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit f9087b4 into master Mar 11, 2025
23 of 25 checks passed
@fmenezes fmenezes deleted the chore_move_tools_to_cmd branch March 11, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants