CLOUDP-305822: atlas dbusers update [USER] --password [PASS]is resetting the roles to an empty array

[andreaangiolillo]

Proposed changes

Jira ticket: CLOUDP-305822

Bug

The atlas dbusers update [USER] --password [PASS] sets the roles and scope array to empty.

Fix

Set the roles and scope in the request body only when the user provides their flags.

Testing

Before

atlas dbusers get Quickstart-1635259359 -P dev -o dev
{
  "awsIAMType": "NONE",
  "databaseName": "admin",
  "groupId": "5e4e593f70dfbf1010295836",
  "labels": [],
  "ldapAuthType": "NONE",
  "links": [
    {
      "href": "https://cloud-dev.mongodb.com/api/atlas/v2/groups/5e4e593f70dfbf1010295836/databaseUsers/admin/Quickstart-1635259359",
      "rel": "self"
    }
  ],
  "oidcAuthType": "NONE",
  "roles": [
    {
      "databaseName": "admin",
      "roleName": "atlasAdmin"
    }
  ],
  "scopes": [],
  "username": "Quickstart-1635259359",
  "x509Type": "NONE"
}

atlas dbusers update Quickstart-1635259359  --password 'test' -P dev -o json                                                                              
{
  "awsIAMType": "NONE",
  "databaseName": "admin",
  "groupId": "5e4e593f70dfbf1010295836",
  "labels": [],
  "ldapAuthType": "NONE",
  "links": [
    {
      "href": "https://cloud-dev.mongodb.com/api/atlas/v2/groups/5e4e593f70dfbf1010295836/databaseUsers/admin/Quickstart-1635259359",
      "rel": "self"
    }
  ],
  "oidcAuthType": "NONE",
  "roles": [],
  "scopes": [],
  "username": "Quickstart-1635259359",
  "x509Type": "NONE"
}

After the fix

./bin/atlas dbusers update thirdUser --password 'test' -P dev -o json                                                                                    
{
  "awsIAMType": "NONE",
  "databaseName": "admin",
  "groupId": "5e4e593f70dfbf1010295836",
  "labels": [],
  "ldapAuthType": "NONE",
  "links": [
    {
      "href": "https://cloud-dev.mongodb.com/api/atlas/v2/groups/5e4e593f70dfbf1010295836/databaseUsers/admin/thirdUser",
      "rel": "self"
    }
  ],
  "oidcAuthType": "NONE",
  "roles": [
    {
      "databaseName": "admin",
      "roleName": "readWriteAnyDatabase"
    },
    {
      "databaseName": "admin",
      "roleName": "clusterMonitor"
    }
  ],
  "scopes": [],
  "username": "thirdUser",
  "x509Type": "NONE"
}

[github-actions]

Coverage Report 📈

Branch	Commit	Coverage
master	415526a	37.9%
CLOUDP-305822	039ddaf	37.9%
	Difference	0%