CLOUDP-304428: Add test that deletes running ASP instance #3727
Conversation
| a.Equal("atlasAdmin", *connection.DbRoleToExecute.Role) | ||
| }) | ||
|
|
||
| t.Run("Delete the streams instance", func(_ *testing.T) { |
There was a problem hiding this comment.
The test still seems to be failing with
[2025/03/11 09:13:42.444] Error: https://cloud-dev.mongodb.com/api/atlas/v2/groups/67d036dfd8722a48d94cb45b DELETE: HTTP 409 Conflict (Error code: "CANNOT_CLOSE_GROUP_ACTIVE_STREAMS_RESOURCE") Detail: Cannot close group while there are Stream Processing instances or private networking connections; please terminate all Stream Processing instances private networking resources (e.g. Private Link, VPC Peering etc). Reason: Conflict. Params: [], BadRequestDetail:
[2025/03/11 09:13:42.444] atlas_e2e_test_generator_test.go:107: 5/5 attempts - trying again in 16 seconds: unexpected error while deleting the project "67d036dfd8722a48d94cb45b": ( (exit status 1))
[2025/03/11 09:13:42.444] atlas_e2e_test_generator_test.go:107: we could not delete the project "67d036dfd8722a48d94cb45b"Do we need to wait for the mms PR to get merged for it to succeed?
There was a problem hiding this comment.
Yes, this is the test that needs the mms change to succeed. This PR only fixes this failure: https://spruce.mongodb.com/task/mongodb_atlas_cli_master_e2e_atlas_streams_with_clusters_atlas_streams_with_cluster_0b94b5c34855a22d6fea9a8f0675fc130eae5577_25_03_05_11_54_37?execution=0&sortBy=STATUS&sortDir=ASC.
If we would like for me to go ahead and disable the atlas_streams tests that are failing I can do that in this PR
There was a problem hiding this comment.
I will actually just go ahead and remove those tests. They can easily be brought back when the mms change has been merged
There was a problem hiding this comment.
Will stop skipping the tests with this ticket: https://jira.mongodb.org/browse/CLOUDP-305842
There was a problem hiding this comment.
we need this same change for https://github.com/mongodb/mongodb-atlas-cli/blob/master/test/e2e/atlas/cleanup_test.go
There was a problem hiding this comment.
I am not familiar with the System Failed status in evergreen that is causing this to report as unhealthy: https://evergreen.mongodb.com/build/mongodb_atlas_cli_master_e2e_generic_patch_8657b42f7f4c1a7581a1d106923b68137ce63861_67d03fda2fbca300078da471_25_03_11_13_51_22?redirect_spruce_users=true
Is there a different change I should be making or should I sync with devprod evergreen on how to proceed?
Also, I am not able to see the results from the github action here: https://github.com/mongodb/mongodb-atlas-cli/actions/runs/13789723995/job/38566942431?pr=3727 I am not sure if this is something we are comfortable just bypassing
There was a problem hiding this comment.
system failed seems related to evg not being able to process the coverage report cc @fmenezes
There was a problem hiding this comment.
The mms cleanup that we wanted for this is merged: https://github.com/10gen/mms/pull/123612. I will wait for it to be deployed to dev, but then I will un skip the tests and that may just "smooth" everything out.
There was a problem hiding this comment.
Thanks! Can you also please revert this commit once you merge from master #3731? I had to comment the test to merge some of our deps updates
test/e2e/atlas/cleanup_test.go
Outdated
| ) | ||
|
|
||
| func TestCleanup(t *testing.T) { | ||
| t.Skip("skipping cleanup test until CLOUDP-305735 is merged") |
There was a problem hiding this comment.
let's not skip this one, @blva can you go over the dangling groups and manually clean them? they all start with atlasStream
there's about ~10 of them
)" This reverts commit 93122d1.
tcannon91
force-pushed
the
CLOUDP-304428
branch
from
07443ad to
bc7eb6d
Compare
3 participants
Proposed changes
Add e2e test step to clean up SPI instances before deleting the cluster.
Jira ticket: CLOUDP-304428
Checklist
make fmtand formatted my code