Skip to content

CLOUDP-304428: Add test that deletes running ASP instance #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2025
Merged

CLOUDP-304428: Add test that deletes running ASP instance #3727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
74a8945
CLOUDP-304428: Add test that deletes running ASP instance
tcannon91 Mar 10, 2025
cabfa8f
Skip failing resource tests
tcannon91 Mar 11, 2025
efd4cb5
Skipping more tests
tcannon91 Mar 11, 2025
00b3974
Do not skip cleanup tests
tcannon91 Mar 11, 2025
b44220c
Remove skip since mms fixes are deployed
tcannon91 Mar 11, 2025
bc7eb6d
Revert "fix: comment streams tests until deletion is fixed (#3731)"
tcannon91 Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions build/ci/evergreen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1245,24 +1245,24 @@ tasks:
MONGODB_ATLAS_SERVICE: cloud
E2E_TAGS: atlas,livemigrations
# Streams commands tests
# - name: atlas_streams
# tags: ["e2e","generic","atlas", "assigned_to_jira_team_cloudp_atlas_streams"]
# must_have_test_results: true
# depends_on:
# - name: compile
# variant: "code_health"
# patch_optional: true
# commands:
# - func: "install gotestsum"
# - func: "e2e test"
# vars:
# MONGODB_ATLAS_ORG_ID: ${atlas_org_id}
# MONGODB_ATLAS_PROJECT_ID: ${atlas_project_id}
# MONGODB_ATLAS_PRIVATE_API_KEY: ${atlas_private_api_key}
# MONGODB_ATLAS_PUBLIC_API_KEY: ${atlas_public_api_key}
# MONGODB_ATLAS_OPS_MANAGER_URL: ${mcli_ops_manager_url}
# MONGODB_ATLAS_SERVICE: cloud
# E2E_TAGS: atlas,streams
- name: atlas_streams
tags: ["e2e","generic","atlas", "assigned_to_jira_team_cloudp_atlas_streams"]
must_have_test_results: true
depends_on:
- name: compile
variant: "code_health"
patch_optional: true
commands:
- func: "install gotestsum"
- func: "e2e test"
vars:
MONGODB_ATLAS_ORG_ID: ${atlas_org_id}
MONGODB_ATLAS_PROJECT_ID: ${atlas_project_id}
MONGODB_ATLAS_PRIVATE_API_KEY: ${atlas_private_api_key}
MONGODB_ATLAS_PUBLIC_API_KEY: ${atlas_public_api_key}
MONGODB_ATLAS_OPS_MANAGER_URL: ${mcli_ops_manager_url}
MONGODB_ATLAS_SERVICE: cloud
E2E_TAGS: atlas,streams
- name: atlas_streams_with_cluster
tags: [ "e2e","streams","atlas","assigned_to_jira_team_cloudp_atlas_streams"]
must_have_test_results: true
Expand Down
16 changes: 16 additions & 0 deletions test/e2e/atlas/streams_with_clusters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,22 @@ func TestStreamsWithClusters(t *testing.T) {
a.Equal(connectionName, *connection.Name)
a.Equal("atlasAdmin", *connection.DbRoleToExecute.Role)
})

t.Run("Delete the streams instance", func(_ *testing.T) {
Copy link
Collaborator

@blva blva Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test still seems to be failing with

 [2025/03/11 09:13:42.444] Error: https://cloud-dev.mongodb.com/api/atlas/v2/groups/67d036dfd8722a48d94cb45b DELETE: HTTP 409 Conflict (Error code: "CANNOT_CLOSE_GROUP_ACTIVE_STREAMS_RESOURCE") Detail: Cannot close group while there are Stream Processing instances or private networking connections; please terminate all Stream Processing instances private networking resources (e.g. Private Link, VPC Peering etc). Reason: Conflict. Params: [], BadRequestDetail: 
 [2025/03/11 09:13:42.444]     atlas_e2e_test_generator_test.go:107: 5/5 attempts - trying again in 16 seconds: unexpected error while deleting the project "67d036dfd8722a48d94cb45b":  ( (exit status 1))
 [2025/03/11 09:13:42.444]     atlas_e2e_test_generator_test.go:107: we could not delete the project "67d036dfd8722a48d94cb45b"

Do we need to wait for the mms PR to get merged for it to succeed?

Copy link
Collaborator Author

@tcannon91 tcannon91 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the test that needs the mms change to succeed. This PR only fixes this failure: https://spruce.mongodb.com/task/mongodb_atlas_cli_master_e2e_atlas_streams_with_clusters_atlas_streams_with_cluster_0b94b5c34855a22d6fea9a8f0675fc130eae5577_25_03_05_11_54_37?execution=0&sortBy=STATUS&sortDir=ASC.

If we would like for me to go ahead and disable the atlas_streams tests that are failing I can do that in this PR

Copy link
Collaborator Author

@tcannon91 tcannon91 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will actually just go ahead and remove those tests. They can easily be brought back when the mms change has been merged

Copy link
Collaborator Author

@tcannon91 tcannon91 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will stop skipping the tests with this ticket: https://jira.mongodb.org/browse/CLOUDP-305842

Copy link
Contributor

@gssbzn gssbzn Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this same change for https://github.com/mongodb/mongodb-atlas-cli/blob/master/test/e2e/atlas/cleanup_test.go

Copy link
Collaborator Author

@tcannon91 tcannon91 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the System Failed status in evergreen that is causing this to report as unhealthy: https://evergreen.mongodb.com/build/mongodb_atlas_cli_master_e2e_generic_patch_8657b42f7f4c1a7581a1d106923b68137ce63861_67d03fda2fbca300078da471_25_03_11_13_51_22?redirect_spruce_users=true

Is there a different change I should be making or should I sync with devprod evergreen on how to proceed?

Also, I am not able to see the results from the github action here: https://github.com/mongodb/mongodb-atlas-cli/actions/runs/13789723995/job/38566942431?pr=3727 I am not sure if this is something we are comfortable just bypassing

Copy link
Contributor

@gssbzn gssbzn Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system failed seems related to evg not being able to process the coverage report cc @fmenezes

Copy link
Collaborator Author

@tcannon91 tcannon91 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mms cleanup that we wanted for this is merged: https://github.com/10gen/mms/pull/123612. I will wait for it to be deployed to dev, but then I will un skip the tests and that may just "smooth" everything out.

Copy link
Collaborator

@blva blva Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also please revert this commit once you merge from master #3731? I had to comment the test to merge some of our deps updates

Copy link
Collaborator Author

@tcannon91 tcannon91 Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

cmd := exec.Command(cliPath,
"streams",
"instance",
"delete",
"--force",
instanceName,
"--projectId",
g.projectID,
)

cmd.Env = os.Environ()
resp, err := e2e.RunAndGetStdOut(cmd)
req.NoError(err, string(resp))
})
}

func generateAtlasConnectionConfigFile(clusterName string) (string, error) {
Expand Down
Loading