CLOUDP-293745: Enable toggling new Data Explorer GenAI project settings #3732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
need-doc-review
|
APIx Bot |
: a message has been sent to Docs Slack channel 🚀.
cveticm
commented
Mar 12, 2025
Comment on lines
+231
to
+234
| EnableDataExplorerGenAIFeatures = "enableDataExplorerGenAIFeatures" // EnableDataExplorerGenAIFeatures flag | ||
| DisableDataExplorerGenAIFeatures = "disableDataExplorerGenAIFeatures" // DisableDataExplorerGenAIFeatures flag | ||
| EnableDataExplorerGenAISampleDocumentPassing = "enableDataExplorerGenAISampleDocumentPassing" //nolint:gosec // EnableDataExplorerGenAISampleDocumentPassing flag | ||
| DisableDataExplorerGenAISampleDocumentPassing = "disableDataExplorerGenAISampleDocumentPassing" // DisableDataExplorerGenAISampleDocumentPassing flag |
There was a problem hiding this comment.
All flags are marked as modified due to realignment. For ease of reviewing, these are the actual modifications to this file.
cveticm
commented
Mar 12, 2025
Comment on lines
293
to
296
| EnableDataExplorerGenAIFeatures = "Flag that enables the Data Explorer GenAI Features project setting." | ||
| DisableDataExplorerGenAIFeatures = "Flag that disables the Data Explorer GenAI Features project setting." | ||
| EnableDataExplorerGenAISampleDocumentPassing = "Flag that enables the Data Explorer GenAI Features project setting." | ||
| DisableDataExplorerGenAISampleDocumentPassing = "Flag that disables the Data Explorer GenAI Sample Document Passing project setting." //nolint:gosec // This is just a message not a credential |
There was a problem hiding this comment.
All usages are marked as modified due to realignment. For ease of reviewing, these are the actual modifications to this file.
cveticm
commented
Mar 12, 2025
Comment on lines
293
to
296
| EnableDataExplorerGenAIFeatures = "Flag that enables the Data Explorer GenAI Features project setting." | ||
| DisableDataExplorerGenAIFeatures = "Flag that disables the Data Explorer GenAI Features project setting." | ||
| EnableDataExplorerGenAISampleDocumentPassing = "Flag that enables the Data Explorer GenAI Features project setting." | ||
| DisableDataExplorerGenAISampleDocumentPassing = "Flag that disables the Data Explorer GenAI Sample Document Passing project setting." //nolint:gosec // This is just a message not a credential |
There was a problem hiding this comment.
//nolint:gosec added to bypass false-positive detection of hardcoded credentials from linter
cveticm
commented
Mar 12, 2025
| DisableDataExplorer = "disableDataExplorer" // DisableDataExplorer flag | ||
| EnableDataExplorerGenAIFeatures = "enableDataExplorerGenAIFeatures" // EnableDataExplorerGenAIFeatures flag | ||
| DisableDataExplorerGenAIFeatures = "disableDataExplorerGenAIFeatures" // DisableDataExplorerGenAIFeatures flag | ||
| EnableDataExplorerGenAISampleDocumentPassing = "enableDataExplorerGenAISampleDocumentPassing" //nolint:gosec // EnableDataExplorerGenAISampleDocumentPassing flag |
There was a problem hiding this comment.
//nolint:gosec added to bypass false-positive detection of hardcoded credentials from linter
internal/usage/usage.go
Outdated
| DisableDataExplorer = "Flag that disables the Data Explorer project setting." | ||
| EnableDataExplorerGenAIFeatures = "Flag that enables the Data Explorer GenAI Features project setting." | ||
| DisableDataExplorerGenAIFeatures = "Flag that disables the Data Explorer GenAI Features project setting." | ||
| EnableDataExplorerGenAISampleDocumentPassing = "Flag that enables the Data Explorer GenAI Features project setting." |
There was a problem hiding this comment.
Suggested change
| EnableDataExplorerGenAISampleDocumentPassing = "Flag that enables the Data Explorer GenAI Features project setting." | |
| EnableDataExplorerGenAISampleDocumentPassing = "Flag that enables the Data Explorer GenAI Sample Document Passing project setting." |
There was a problem hiding this comment.
Thanks for catching! Fixed now 👍
fmenezes
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The two new project settings have been enabled
These settings now toggleable using
--enable/disable<feature-name>The state of the setting will now also be displayed on running
atlas projects settings describeJira ticket: CLOUDP-293745
Checklist
make fmtand formatted my code