Skip to content

CLOUDP-309137: search e2e tests #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

CLOUDP-309137: search e2e tests #3786

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
772e82e
test
andreaangiolillo Mar 28, 2025
4d32785
No need to wait since we then delete the cluster
andreaangiolillo Mar 28, 2025
927eaee
Update search_nodes_test.go
andreaangiolillo Mar 28, 2025
7a923f9
Update search_nodes_test.go
andreaangiolillo Mar 28, 2025
a3fa924
Update search_nodes_test.go
andreaangiolillo Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cli/search/nodes/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (opts *DeleteOpts) watcher() (any, bool, error) {
return nil, false, err
}

// atlas clusters search nodes delete [--clusterName clusterName].
// DeleteBuilder defines the cobra command for atlas clusters search nodes delete [--clusterName clusterName].
func DeleteBuilder() *cobra.Command {
opts := &DeleteOpts{
DeleteOpts: cli.NewDeleteOptsWithPrompt(deleteTemplate, "Search node not deleted.", "Are you sure you want to delete search nodes for cluster: %s"),
Expand Down
1 change: 1 addition & 0 deletions test/e2e/helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ const (
suggestedIndexesEntity = "suggestedIndexes"
slowOperationThresholdEntity = "slowOperationThreshold"
tierM10 = "M10"
tierM20 = "M20"
tierM0 = "M0"
tierM2 = "M2"
diskSizeGB40 = "40"
Expand Down
7 changes: 3 additions & 4 deletions test/e2e/search_nodes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestSearchNodes(t *testing.T) {
req.NoError(err)

g.generateProject("searchNodes")
g.tier = tierM10
g.tier = tierM20
g.mDBVer = minSearchNodesMDBVersion
g.generateCluster()

Expand All @@ -57,8 +57,8 @@ func TestSearchNodes(t *testing.T) {
resp, err := cmd.CombinedOutput()
respStr := string(resp)

require.Error(t, err, respStr)
require.Contains(t, respStr, "ATLAS_SEARCH_DEPLOYMENT_DOES_NOT_EXIST", respStr)
require.NoError(t, err, respStr)
require.Empty(t, respStr)
Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:hide_the_pain_andrea 😞

./bin/atlas cluster search nodes ls -P dev1 --clusterName cluster-924-2d65cdd1524 -o json                                                                     
{}

})

t.Run("Create search node", func(t *testing.T) {
Expand Down Expand Up @@ -186,7 +186,6 @@ func TestSearchNodes(t *testing.T) {
"--clusterName", g.clusterName,
"--projectId", g.projectID,
"--force",
"-w",
"-o=json",
)

Expand Down