Skip to content

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Apr 15, 2025

Proposed changes

This moves all e2e snapshotted tests into one and moves it into code_health (currently it takes 7 minutes in comparison unit tests take 4 minutes)

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes force-pushed the chore_split_test_packages branch from 46bcfca to e094963 Compare April 15, 2025 17:03
@fmenezes fmenezes force-pushed the chore_split_test_packages branch 9 times, most recently from c16f57f to ab98d2f Compare April 16, 2025 13:40
@fmenezes fmenezes force-pushed the chore_split_test_packages branch from ab98d2f to 288340d Compare April 16, 2025 13:40
@fmenezes fmenezes force-pushed the chore_split_test_packages branch from 17f83bf to a96840d Compare April 16, 2025 14:36
@fmenezes fmenezes force-pushed the chore_split_test_packages branch from 29b91c7 to 33dd6fb Compare April 16, 2025 16:10
@fmenezes fmenezes marked this pull request as ready for review April 16, 2025 17:05
@fmenezes fmenezes requested a review from a team as a code owner April 16, 2025 17:05
@fmenezes fmenezes changed the title chore: split test packages chore: move e2e tests into code_health Apr 16, 2025
@fmenezes
Copy link
Collaborator Author

evergreen failures are unrelated

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 29 to 31
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"

Comment on lines 26 to 28
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"

Comment on lines 25 to 27
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"

Comment on lines 23 to 25
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"

Comment on lines 24 to 26
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"

Comment on lines 24 to 26
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// e2eClusterTier = "M10"
// e2eGovClusterTier = "M20"
// e2eSharedClusterTier = "M2"

@fmenezes fmenezes enabled auto-merge (squash) April 17, 2025 14:26
@fmenezes fmenezes force-pushed the chore_split_test_packages branch from 3dd1608 to 3eda679 Compare April 17, 2025 14:26
@fmenezes fmenezes merged commit b30e560 into master Apr 17, 2025
19 of 20 checks passed
@fmenezes fmenezes deleted the chore_split_test_packages branch April 17, 2025 14:31
@github-actions
Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
master 38a29de 36.6%
chore_split_test_packages 3eda679 36.6%
Difference 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants