-
Notifications
You must be signed in to change notification settings - Fork 88
chore: move e2e tests into code_health #3828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
46bcfca to
e094963
Compare
c16f57f to
ab98d2f
Compare
ab98d2f to
288340d
Compare
17f83bf to
a96840d
Compare
29b91c7 to
33dd6fb
Compare
|
evergreen failures are unrelated |
andreaangiolillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| // e2eClusterTier = "M10" | ||
| // e2eGovClusterTier = "M20" | ||
| // e2eSharedClusterTier = "M2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // e2eClusterTier = "M10" | |
| // e2eGovClusterTier = "M20" | |
| // e2eSharedClusterTier = "M2" |
test/e2e/backupsnapshot/constants.go
Outdated
| // e2eClusterTier = "M10" | ||
| // e2eGovClusterTier = "M20" | ||
| // e2eSharedClusterTier = "M2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // e2eClusterTier = "M10" | |
| // e2eGovClusterTier = "M20" | |
| // e2eSharedClusterTier = "M2" |
test/e2e/clustersflags/constants.go
Outdated
| // e2eClusterTier = "M10" | ||
| // e2eGovClusterTier = "M20" | ||
| // e2eSharedClusterTier = "M2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // e2eClusterTier = "M10" | |
| // e2eGovClusterTier = "M20" | |
| // e2eSharedClusterTier = "M2" |
test/e2e/clustersflex/constants.go
Outdated
| // e2eClusterTier = "M10" | ||
| // e2eGovClusterTier = "M20" | ||
| // e2eSharedClusterTier = "M2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // e2eClusterTier = "M10" | |
| // e2eGovClusterTier = "M20" | |
| // e2eSharedClusterTier = "M2" |
test/e2e/clustersm0/constants.go
Outdated
| // e2eClusterTier = "M10" | ||
| // e2eGovClusterTier = "M20" | ||
| // e2eSharedClusterTier = "M2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // e2eClusterTier = "M10" | |
| // e2eGovClusterTier = "M20" | |
| // e2eSharedClusterTier = "M2" |
| // e2eClusterTier = "M10" | ||
| // e2eGovClusterTier = "M20" | ||
| // e2eSharedClusterTier = "M2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // e2eClusterTier = "M10" | |
| // e2eGovClusterTier = "M20" | |
| // e2eSharedClusterTier = "M2" |
3dd1608 to
3eda679
Compare
Proposed changes
This moves all e2e snapshotted tests into one and moves it into code_health (currently it takes 7 minutes in comparison unit tests take 4 minutes)
Jira ticket: CLOUDP-#
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments