-
Notifications
You must be signed in to change notification settings - Fork 88
CLOUDP-315273: Onboard Papertrail #3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build/ci/release.yml
Outdated
| unstable: ${unstable} | ||
| script: | | ||
| # Get unstable | ||
| if [[ "${unstable}" == "-unstable" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if [[ "${unstable}" == "-unstable" ]]; then | |
| if [[ "${unstable:-}" == "-unstable" ]]; then |
avoid issues if the value is not set
build/ci/release.yml
Outdated
| env: | ||
| unstable: ${unstable} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need
maybe
include_expansions_in_env:
- unstable
``There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I see in the EVG docs that include_expansions_in_env has greater priority than env so happy to do the change.
Is this the reason for this suggestion or is there another reason to do one over the other?
build/ci/release.yml
Outdated
| fi | ||
| cat <<EOT > expansions.yaml | ||
| product_name: "$product_name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at https://github.com/10gen/release-infrastructure-papertrail?tab=readme-ov-file#required-metadata:
I see that there are a few different metadata fields to include that are missing here. Do you plan to add them later or we don't need them? Also they use product instead of product_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Evergreen task papertrail.trace only takes:
- work_dir
- key_id
- secret_key
- product
- version
- filename
Evergreen then takes care of the remaining fields as, in the test Papertrail stamp, we see information like submitter and sha256 are included.
Also, use of product_name instead of product for the env var was arbitrary. Will change it to product for clarity.
Proposed changes
Sets up new step in release process to lodge metadata in Papertrail for each release.
The metadata is made up of:
Product names are:
See here for test Papertrail run: https://papertrail.prod.corp.mongodb.com/product-version?product=atlascli-test&version=1.42.2
Associated patch: https://spruce.mongodb.com/task/mongodb_atlas_cli_master_test_papertrail_papertrail_test_patch_7d2dbe767468643cb196297868a7d1e9999bcbbc_682ca4ec0ef6fc00071ecdb4_25_05_20_15_51_15/logs?execution=0&logtype=all
Note: You will notice that the only file for each papertrail entry in atlascli-test version 1.42.2 is
.keep. This was the test file used for testing.Jira ticket: CLOUDP-315273
Checklist
make fmtand formatted my code