Skip to content

Conversation

@cveticm
Copy link
Collaborator

@cveticm cveticm commented May 20, 2025

Proposed changes

Sets up new step in release process to lodge metadata in Papertrail for each release.
The metadata is made up of:

  • release version
  • filenames of each package

Product names are:

  • atlascli - for stable releases
  • atlascli-snapshot - for unstable releases
  • atlascli-test - for testing

See here for test Papertrail run: https://papertrail.prod.corp.mongodb.com/product-version?product=atlascli-test&version=1.42.2
Associated patch: https://spruce.mongodb.com/task/mongodb_atlas_cli_master_test_papertrail_papertrail_test_patch_7d2dbe767468643cb196297868a7d1e9999bcbbc_682ca4ec0ef6fc00071ecdb4_25_05_20_15_51_15/logs?execution=0&logtype=all
Note: You will notice that the only file for each papertrail entry in atlascli-test version 1.42.2 is .keep. This was the test file used for testing.

Jira ticket: CLOUDP-315273

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

@cveticm cveticm requested a review from a team as a code owner May 20, 2025 16:04
unstable: ${unstable}
script: |
# Get unstable
if [[ "${unstable}" == "-unstable" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [[ "${unstable}" == "-unstable" ]]; then
if [[ "${unstable:-}" == "-unstable" ]]; then

avoid issues if the value is not set

Comment on lines 188 to 189
env:
unstable: ${unstable}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need

maybe

        include_expansions_in_env:
          - unstable
``

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I see in the EVG docs that include_expansions_in_env has greater priority than env so happy to do the change.

Is this the reason for this suggestion or is there another reason to do one over the other?

@cveticm cveticm requested a review from blva May 21, 2025 10:06
fi
cat <<EOT > expansions.yaml
product_name: "$product_name"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://github.com/10gen/release-infrastructure-papertrail?tab=readme-ov-file#required-metadata:
I see that there are a few different metadata fields to include that are missing here. Do you plan to add them later or we don't need them? Also they use product instead of product_name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Evergreen task papertrail.trace only takes:

  • work_dir
  • key_id
  • secret_key
  • product
  • version
  • filename

Evergreen then takes care of the remaining fields as, in the test Papertrail stamp, we see information like submitter and sha256 are included.

Also, use of product_name instead of product for the env var was arbitrary. Will change it to product for clarity.

@cveticm cveticm enabled auto-merge (squash) May 21, 2025 10:28
@github-actions
Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
master 7d2dbe7 25.1%
CLOUDP-315273_onboard_papertrail 3861e1f 25.1%
Difference 0%

@cveticm cveticm merged commit ced6b1f into master May 21, 2025
20 of 21 checks passed
@cveticm cveticm deleted the CLOUDP-315273_onboard_papertrail branch May 21, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants