Skip to content

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented May 30, 2025

Proposed changes

This PR simplifies and improves the Windows package building process for the MongoDB Atlas CLI. It moves away from using a dedicated MSI build task in Evergreen to a more integrated approach with GoReleaser.

Changes:

  • Removed the separate MSI packaging task - Eliminated the standalone package_msi task and its associated variant in Evergreen
  • Integrated MSI building into GoReleaser - Modified the GoReleaser workflow to handle MSI generation as part of the regular build process (hook after generating .exe)
  • Reorganized MSI-related files - Moved MSI templates and build scripts into msi folder
  • MSI file now contain signed executable - Previously, MSIs contained unsigned versions of the .exe files, now they include the properly signed versions

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Coverage Report 📈

Branch Commit Coverage
master c6609e9 25.1%
chore_remove_msi_task 77e5fe3 25.1%
Difference 0%

@fmenezes fmenezes marked this pull request as ready for review June 4, 2025 10:52
@fmenezes fmenezes requested a review from a team as a code owner June 4, 2025 10:52
@fmenezes fmenezes merged commit 525940e into master Jun 5, 2025
25 checks passed
@fmenezes fmenezes deleted the chore_remove_msi_task branch June 5, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants